-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run browser tests without circle #3328
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3328 +/- ##
==========================================
+ Coverage 93.43% 93.45% +0.01%
==========================================
Files 241 241
Lines 7253 7253
Branches 1507 1507
==========================================
+ Hits 6777 6778 +1
+ Misses 476 475 -1
|
@open-telemetry/javascript-approvers since the recent release of actions/core this PR is blocking all other PRs so please approve ASAP |
Seems like karma has some problems with node v18: https://github.com/open-telemetry/opentelemetry-js/actions/runs/3243835797/jobs/5319134741 https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported maybe we need to downgrade to Node.js v16 instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this 🙂
It's good to have a permanent fix for this.
The circle ci image we've been using for testing was causing permissions issues in github actions. This was the original reason for the permission setting in the action run. Chrome has since been added to the default runner so we actually don't need the image at all.