Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release SDK 1.8.0 / Experimental 0.34.0 with metrics GA #3340

Merged
merged 25 commits into from
Nov 9, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 17, 2022

This graduates the metrics API and SDK to GA. The exporters are still not yet moved. If there are other packages which should be moved comment below with your reasoning. If there are PRs or issues which should block this release, comment below and I will add them to this PR description.

Blocking issues / PRs:


SDK 1.8.0

  • @opentelemetry/sdk-metrics has been promoted to stable

🚀 (Enhancement)

🐛 (Bug Fix)

  • fix(sdk-trace): enforce consistent span durations
    #3327 @dyladan
  • fix(resources): fix EnvDetector throwing errors when attribute values contain spaces
    #3295
  • fix(trace): fix an issue which caused negative span durations in web based spans
    #3359 @dyladan
  • fix(resources): strict OTEL_RESOURCE_ATTRIBUTES baggage octet decoding
    #3341 @legendecas

🏠 (Internal)

Experimental 0.34.0

  • @opentelemetry/sdk-metrics moved to packages/sdk-metrics
  • @opentelemetry/api-metrics deprecated and merged into api

🚀 (Enhancement)

  • feat(metrics-sdk): Add tracing suppresing for Metrics Export #3332 @hectorhdzg
  • feat(instrumentation): implement require-in-the-middle singleton #3161 @mhassan1
  • feat(sdk-node): configure trace exporter with environment variables #3143 @svetlanabrennan
  • feat: enable tree shaking #3329 @pkanal
  • feat(prometheus): serialize resource as target_info gauge #3300 @pichlermarc
  • feat(detectors): add browser detector module #3292 @Abinet18
  • deps: remove unused proto-loader dependencies and update grpc-js and proto-loader versions #3337 @seemk
  • feat(metrics-exporters): configure temporality via environment variable #3305 @pichlermarc

🐛 (Bug Fix)

  • fix(node-sdk): move @opentelemetry/semantic-conventions to dependencies #3283 @mhassan1
  • fix(exporters): do not append trailing '/' when URL contains path #3274 @pichlermarc
  • fix(instrumentation): debug log on no modules defined for instrumentation #3308 @legendecas

📚 (Refine Doc)

  • docs(metrics-exporters): fix wrong exporter const name in example #3270 @pichlermarc

🏠 (Internal)

  • ci(instrumentation-http): remove got devDependency
    #3347 @dyladan
  • deps(instrumentation-http): move sdk-metrics to dev dependencies #3380 @pichlermarc

@dyladan dyladan requested a review from a team October 17, 2022 13:28
@dyladan dyladan changed the title chore: graduate metrics api/sdk to GA chore: release 1.8.0 / 0.34.0 with metrics GA Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #3340 (e3054d2) into main (baf0fee) will decrease coverage by 0.51%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
- Coverage   93.77%   93.25%   -0.52%     
==========================================
  Files          45      247     +202     
  Lines         643     7344    +6701     
  Branches      102     1511    +1409     
==========================================
+ Hits          603     6849    +6246     
- Misses         40      495     +455     
Impacted Files Coverage Δ
packages/sdk-metrics/src/InstrumentDescriptor.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/Instruments.ts 94.59% <ø> (ø)
packages/sdk-metrics/src/Meter.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/MeterProvider.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/ObservableResult.ts 95.83% <ø> (ø)
packages/sdk-metrics/src/aggregator/Drop.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/aggregator/Histogram.ts 92.00% <ø> (ø)
packages/sdk-metrics/src/aggregator/LastValue.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/aggregator/Sum.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/aggregator/index.ts 100.00% <ø> (ø)
... and 239 more

@dyladan
Copy link
Member Author

dyladan commented Oct 17, 2022

/easycla

@weyert
Copy link
Contributor

weyert commented Oct 17, 2022

Awesome, super excited about Metrics going v1 :))

@dyladan dyladan marked this pull request as draft October 17, 2022 21:17
@dyladan
Copy link
Member Author

dyladan commented Oct 17, 2022

Converting to draft as it seems my approach must have had some fundamental flaw somewhere and I want to have confidence that the version change is good before making too many people look at this.

@anthony-telljohann
Copy link
Contributor

anthony-telljohann commented Oct 18, 2022

I propose we postpone this release until #3341 is merged. I think it makes sense to wait until EnvDetector correctly handles decoding the OTEL_RESOURCE_ATTRIBUTES environment variable. If we were to release without it, I think it is fair to say EnvDetector is in a better state than before but it is still not working as intended.

@dyladan dyladan marked this pull request as ready for review October 27, 2022 21:07
@weyert
Copy link
Contributor

weyert commented Oct 28, 2022

Note: This is an experimental package under active development. New releases may include breaking changes.

Do we want to remove the references to this in some Metrics packages's README files?

@dyladan
Copy link
Member Author

dyladan commented Nov 1, 2022

Note: This is an experimental package under active development. New releases may include breaking changes.

Do we want to remove the references to this in some Metrics packages's README files?

Yes we definitely do. I'm holding this right now while we resolve #3368

@pkanal
Copy link
Contributor

pkanal commented Nov 2, 2022

Does this release include the tree shaking change? It's definitely in main but I don't see it in the release description in this PR.

@dyladan
Copy link
Member Author

dyladan commented Nov 2, 2022

Yes I just haven't updated the description. I'll update it

@dyladan dyladan changed the title chore: release 1.8.0 / 0.34.0 with metrics GA chore: release API 1.3.0 / SDK 1.8.0 / Experimental 0.34.0 with metrics GA Nov 4, 2022
@dyladan
Copy link
Member Author

dyladan commented Nov 4, 2022

@open-telemetry/javascript-approvers this now contains an API minor version bump with metrics. Please review it so we can release metrics.

@dyladan
Copy link
Member Author

dyladan commented Nov 4, 2022

All I am going to let this go for the weekend at least to let people review it and try to release monday if there are a few approvals. Enjoy your weekends.

@legendecas
Copy link
Member

Worth noting that we've got comments on the GA interface in the TC review on metric API/SDK: open-telemetry/community#1204

@dyladan
Copy link
Member Author

dyladan commented Nov 7, 2022

Converting back to draft until the API questions are resolved. I'll open another release PR which releases the other packages with important fixes.

@dyladan
Copy link
Member Author

dyladan commented Nov 8, 2022

Going to release this in the morning

@dyladan
Copy link
Member Author

dyladan commented Nov 9, 2022

I'm not sure what is causing the bootstrap to fail but we obviously can't merge like this

@dyladan dyladan changed the title chore: release API 1.3.0 / SDK 1.8.0 / Experimental 0.34.0 with metrics GA chore: release SDK 1.8.0 / Experimental 0.34.0 with metrics GA Nov 9, 2022
@dyladan dyladan merged commit 7972edf into open-telemetry:main Nov 9, 2022
@dyladan dyladan deleted the metrics-ga branch November 9, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants