Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter-logs-otlp-grpc): change OTLPLogsExporter to OTLPLogExpo… #3819

Merged
merged 4 commits into from
May 22, 2023

Conversation

fuaiyi
Copy link
Contributor

@fuaiyi fuaiyi commented May 18, 2023

Which problem is this PR solving?

feat(exporter-logs-otlp-grpc): change OTLPLogsExporter to OTLPLogExpo…

Fixes #3812

Short description of the changes

Update logs gRPC exporter class name to singular OTLPLogExporter #3812

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Run the included unit tests.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@fuaiyi fuaiyi requested a review from a team May 18, 2023 08:20
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #3819 (643b39e) into main (de22983) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 643b39e differs from pull request most recent head e267b37. Consider uploading reports for the commit e267b37 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3819   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files         295      295           
  Lines        9039     9039           
  Branches     1843     1843           
=======================================
  Hits         8403     8403           
  Misses        636      636           
Impacted Files Coverage Δ
...ges/exporter-logs-otlp-grpc/src/OTLPLogExporter.ts 92.30% <100.00%> (ø)

@fuaiyi
Copy link
Contributor Author

fuaiyi commented May 18, 2023

@dyladan @martinkuba cc~ fixed: #3812

experimental/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

@pichlermarc pichlermarc merged commit 0471c54 into open-telemetry:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update logs gRPC exporter class name to singular OTLPLogExporter
3 participants