Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logs gRPC exporter class name to singular OTLPLogExporter #3812

Closed
dyladan opened this issue May 17, 2023 · 3 comments · Fixed by #3819
Closed

Update logs gRPC exporter class name to singular OTLPLogExporter #3812

dyladan opened this issue May 17, 2023 · 3 comments · Fixed by #3819

Comments

@dyladan
Copy link
Member

dyladan commented May 17, 2023

I did just notice that the name of this class has singular Log in its name, which is inconsistent with the existing gRPC exporter which has plural Logs. I think OTLPLogExporter (singular as here) is the right name - it's consistent with OTLPMetricExporter and OTLPTraceExporter, so I would leave it here as is, but we might want to go back and update the gRPC class name.

Originally posted by @martinkuba in #3764 (comment)

@fuaiyi
Copy link
Contributor

fuaiyi commented May 18, 2023

I have submitted a PR to address this issue. #3819

fuaiyi added a commit to fuaiyi/opentelemetry-js that referenced this issue May 19, 2023
@pichlermarc
Copy link
Member

Seems like this problem is still present: main/experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogsExporter.ts#L40 (blame)

@Vunovati ah yes, that's a different exporter; please open a new issue so that we can track it separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants