-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logs gRPC exporter class name to singular OTLPLogExporter
#3812
Comments
I have submitted a PR to address this issue. #3819 |
Seems like this problem is still present: https://github.com/open-telemetry/opentelemetry-js/blame/main/experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogsExporter.ts#L40 |
@Vunovati ah yes, that's a different exporter; please open a new issue so that we can track it separately. |
I did just notice that the name of this class has singular
Log
in its name, which is inconsistent with the existing gRPC exporter which has pluralLogs
. I thinkOTLPLogExporter
(singular as here) is the right name - it's consistent withOTLPMetricExporter
andOTLPTraceExporter
, so I would leave it here as is, but we might want to go back and update the gRPC class name.Originally posted by @martinkuba in #3764 (comment)
The text was updated successfully, but these errors were encountered: