Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto logs exporter class name inconsistent with other logs exporters #4139

Closed
Vunovati opened this issue Sep 12, 2023 · 0 comments · Fixed by #4140
Closed

Proto logs exporter class name inconsistent with other logs exporters #4139

Vunovati opened this issue Sep 12, 2023 · 0 comments · Fixed by #4140

Comments

@Vunovati
Copy link
Contributor

Vunovati commented Sep 12, 2023

There is a naming inconsistency in the @opentelemetry/exporter-logs-otlp-proto package, identical to #3812

First mentioned in this commit: #3764 (comment)

I originally posted the comment in the existing issue that was closed, but this is actually a different package so it should be tracked separately.

Seems like this problem is still present: main/experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogsExporter.ts#L40 (blame)

@Vunovati ah yes, that's a different exporter; please open a new issue so that we can track it separately.

Originally posted by @pichlermarc in #3812 (comment)

Vunovati added a commit to Vunovati/opentelemetry-js that referenced this issue Sep 12, 2023
Vunovati added a commit to Vunovati/opentelemetry-js that referenced this issue Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant