fix(instrumentation): allow different export types for files within a Node module #4046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
InstrumentationModuleDefinition<T>
interface defines a propertyfiles: InstrumentationModuleFile<any>[]
.InstrumentationNodeModuleDefinition<T>
implements this interface but defines the property asfiles: InstrumentationModuleFile<T>[]
. This implies that all files within the module have the same exports type, which is unlikely! As a result, you cannot (for example) call.push()
on the files field without type casting.Short description of the changes
This PR changes the type of the property in the class to match the interface it implements.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
npm run compile
Checklist:
Unit tests have been addedDocumentation has been updated