Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation): allow different export types for files within a Node module #4046

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ All notable changes to experimental packages in this project will be documented

### :bug: (Bug Fix)

* fix(instrumentation): allow different export types for files within a Node module [#4046](https://github.com/open-telemetry/opentelemetry-js/pull/4046) @haines

### :books: (Refine Doc)

### :house: (Internal)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
export class InstrumentationNodeModuleDefinition<T>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyladan I seem to remember that we discussed changing this to <T=any> at some point so that it can be left out for reasons like this. WDYT?

implements InstrumentationModuleDefinition<T>
{
files: InstrumentationModuleFile<T>[];
files: InstrumentationModuleFile<any>[];
constructor(
public name: string,
public supportedVersions: string[],
Expand Down