-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opencensus-shim): implement OpenCensus metric producer #4066
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4066 +/- ##
==========================================
+ Coverage 92.24% 92.30% +0.06%
==========================================
Files 326 328 +2
Lines 9299 9385 +86
Branches 1971 1993 +22
==========================================
+ Hits 8578 8663 +85
- Misses 721 722 +1 |
35a6582
to
05fcd92
Compare
05fcd92
to
86ebf54
Compare
86ebf54
to
15e00a9
Compare
15e00a9
to
7398cc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and it would be better to add a code document about the difference mentioned above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; I think we need to add one copyright notice then this should be good to merge. 🙂
…ucer.ts Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
@pichlermarc done |
Good to merge? |
Which problem is this PR solving?
Part of #3461
Short description of the changes
Implements OpenCensus Metric Producer, which acts as the metrics bridge. See attached bug.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: