Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update OpenCensus shim example for metrics #4078

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Aug 18, 2023

Which problem is this PR solving?

Fixes #3461

Short description of the changes

Add documentation for using OpenCensus shim to pipe metrics to OTel. This is the last PR for the shim.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Added screenshots of working example

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass changed the title oc shim producer2 docs: update OpenCensus shim example for metrics Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #4078 (f75f5dc) into main (be16272) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head f75f5dc differs from pull request most recent head 5cf9edf. Consider uploading reports for the commit 5cf9edf to get more accurate results

@@            Coverage Diff             @@
##             main    #4078      +/-   ##
==========================================
+ Coverage   92.29%   92.30%   +0.01%     
==========================================
  Files         328      328              
  Lines        9385     9385              
  Branches     1993     1993              
==========================================
+ Hits         8662     8663       +1     
+ Misses        723      722       -1     

@aabmass aabmass force-pushed the oc-shim-producer2 branch 2 times, most recently from f6180b7 to d1c4961 Compare September 15, 2023 15:44
@aabmass aabmass marked this pull request as ready for review September 15, 2023 15:46
@aabmass aabmass requested a review from a team September 15, 2023 15:46
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating the docs/example! 🙂

@pichlermarc pichlermarc added Skip Changelog document Documentation-related labels Sep 19, 2023
@pichlermarc pichlermarc merged commit cbc5c52 into open-telemetry:main Sep 19, 2023
17 of 18 checks passed
@aabmass aabmass deleted the oc-shim-producer2 branch September 19, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenCensus metric bridge
2 participants