Collector exporter #552

obecny · 2019-11-20T18:29:23Z

Which problem is this PR solving?

Short description of the changes

It adds new CollectorExporter for web and node. It will export spans either from web or node to opentelemetry-collector using the opencensus receiver. There is one docker compose file inside examples/basic-tracer-node/docker.

codecov-io · 2019-11-20T18:38:53Z

Codecov Report

Merging #552 into master will decrease coverage by 0.21%.
The diff coverage is 69.26%.

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   90.16%   89.94%   -0.22%     
==========================================
  Files         146      168      +22     
  Lines        7390     8238     +848     
  Branches      631      739     +108     
==========================================
+ Hits         6663     7410     +747     
- Misses        727      828     +101

Impacted Files	Coverage Δ
...-exporter-collector/src/platform/node/sendSpans.ts	`0% <0%> (ø)`
...metry-exporter-collector/scripts/version-update.js	`0% <0%> (ø)`
...kages/opentelemetry-core/scripts/version-update.js	`0% <0%> (ø)`
...y-exporter-collector/test/common/transform.test.ts	`0% <0%> (ø)`
packages/opentelemetry-core/src/common/time.ts	`95.38% <100%> (+0.46%)`	⬆️
...ckages/opentelemetry-core/test/common/time.test.ts	`100% <100%> (ø)`	⬆️
...es/opentelemetry-exporter-collector/src/version.ts	`100% <100%> (ø)`
...y-exporter-collector/test/browser/index-webpack.ts	`100% <100%> (ø)`
packages/opentelemetry-core/src/common/version.ts	`100% <100%> (ø)`
...ages/opentelemetry-exporter-collector/src/types.ts	`100% <100%> (ø)`
... and 44 more

obecny · 2019-11-20T18:39:23Z

cc @draffensperger

mayurkale22

This is great 💯, added few minor comments in the first pass. I will spend some time today to review the rest of the conversation stuff.

examples/basic-tracer-node/README.md

packages/opentelemetry-exporter-collector/README.md

packages/opentelemetry-exporter-collector/src/platform/node/sendSpans.ts

mayurkale22

Addded a few more comments.

packages/opentelemetry-exporter-collector/src/util.ts

packages/opentelemetry-core/src/platform/browser/span-id-to-base64.ts

packages/opentelemetry-core/src/platform/node/span-id-to-base64.ts

packages/opentelemetry-exporter-collector/src/types.ts

packages/opentelemetry-exporter-collector/src/util.ts

packages/opentelemetry-exporter-collector/src/types.ts

packages/opentelemetry-exporter-collector/src/util.ts

packages/opentelemetry-exporter-collector/src/types.ts

packages/opentelemetry-exporter-collector/test/common/transform.test.ts

packages/opentelemetry-exporter-collector/src/CollectorExporter.ts

packages/opentelemetry-exporter-collector/src/platform/node/sendSpans.ts

packages/opentelemetry-exporter-collector/src/platform/browser/sendSpans.ts

draffensperger

Very cool! Have some comments but awesome to see this coming together.

packages/opentelemetry-core/src/platform/browser/hex-to-base64.ts

packages/opentelemetry-core/src/common/time.ts

packages/opentelemetry-exporter-collector/src/CollectorExporter.ts

packages/opentelemetry-exporter-collector/src/platform/browser/sendSpans.ts

packages/opentelemetry-exporter-collector/src/transform.ts

draffensperger · 2019-11-21T15:23:20Z

packages/opentelemetry-exporter-collector/src/transform.ts

+        annotation.attributes = attributes;
+      }
+
+      // const messageEvent: MessageEvent;


Should we open a tracking issue for us to add message events? @mayurkale22 / @bg451 is that in the spec?

AFAIK we can use event.attributes to assign the MessageEventType (RECEIVED or SEND) and uncompressedSize and compressedSize bytes instead of adding dedicated api for message event. Maybe you should open an issue to define semantic conversions for all of these attributes.

packages/opentelemetry-exporter-collector/src/transform.ts

packages/opentelemetry-core/src/platform/browser/hex-to-base64.ts

packages/opentelemetry-core/src/platform/node/hex-to-base64.ts

packages/opentelemetry-core/src/platform/browser/hex-to-base64.ts

packages/opentelemetry-exporter-collector/src/CollectorExporter.ts

packages/opentelemetry-exporter-collector/src/platform/node/sendSpans.ts

packages/opentelemetry-exporter-collector/src/transform.ts

packages/opentelemetry-core/scripts/version-update.js

packages/opentelemetry-exporter-collector/src/types.ts

mayurkale22 · 2019-11-25T21:49:24Z

packages/opentelemetry-exporter-collector/src/transform.ts

+        annotation.attributes = attributes;
+      }
+
+      // const messageEvent: MessageEvent;


AFAIK we can use event.attributes to assign the MessageEventType (RECEIVED or SEND) and uncompressedSize and compressedSize bytes instead of adding dedicated api for message event. Maybe you should open an issue to define semantic conversions for all of these attributes.

packages/opentelemetry-exporter-collector/src/types.ts

packages/opentelemetry-exporter-collector/src/version.ts

bg451

Awesome work @obecny!

packages/opentelemetry-core/src/common/time.ts

packages/opentelemetry-exporter-collector/src/CollectorExporter.ts

mayurkale22

LGTM, added a few minor comments. Great work! 💯

packages/opentelemetry-exporter-collector/package.json

packages/opentelemetry-exporter-collector/src/CollectorExporter.ts

packages/opentelemetry-exporter-collector/src/platform/browser/sendSpans.ts

packages/opentelemetry-exporter-collector/src/platform/node/sendSpans.ts

mayurkale22 · 2019-12-02T18:15:08Z

@open-telemetry/javascript-approvers Please review when you get a chance.

vmarchaud

🚀

obecny added 3 commits November 20, 2019 17:13

chore: linting

abaadf8

feat(collector-exporter): new exporter for opentelemetry collector

7af153f

chore: updating readme

48818fb

obecny requested review from bg451, danielkhan, markwolff, mayurkale22, OlivierAlbertini, rochdev and vmarchaud as code owners November 20, 2019 18:29

chore: undo auto lint fix - which is wrong

1cbf4c6

mayurkale22 reviewed Nov 20, 2019

View reviewed changes

chore: updates after comments

952f99d

mayurkale22 reviewed Nov 21, 2019

View reviewed changes

packages/opentelemetry-exporter-collector/src/util.ts Outdated Show resolved Hide resolved

obecny added 2 commits November 21, 2019 01:43

chore: renaming util to transform

1fe92b8

chore: renaming types, last comments from review

eb1bb4f

mayurkale22 reviewed Nov 21, 2019

View reviewed changes

packages/opentelemetry-exporter-collector/src/types.ts Outdated Show resolved Hide resolved

packages/opentelemetry-exporter-collector/test/common/transform.test.ts Outdated Show resolved Hide resolved

chore: adding missing links

c09bc5c

mayurkale22 reviewed Nov 21, 2019

View reviewed changes

draffensperger reviewed Nov 21, 2019

View reviewed changes

dyladan reviewed Nov 21, 2019

View reviewed changes

obecny added 6 commits November 22, 2019 17:25

chore: fixes after comments

4920633

chore: fixes after comments

7c2923b

chore: fixes after comments

a42d992

chore: updating jsdoc

e3203f0

chore: enabling attributes

dfbbc94

chore: adding script to generate package version file

08d8f8c

draffensperger reviewed Nov 25, 2019

View reviewed changes

packages/opentelemetry-core/scripts/version-update.js Outdated Show resolved Hide resolved

dyladan reviewed Nov 25, 2019

View reviewed changes

packages/opentelemetry-exporter-collector/src/types.ts Outdated Show resolved Hide resolved

mayurkale22 reviewed Nov 25, 2019

View reviewed changes

obecny added 5 commits November 26, 2019 02:54

chore: updating types for link

bfea4ca

chore: fixing typo

bab3be3

chore: removing unnecessary typing

a000724

chore: const for enum

03d8c8b

chore: adding missing interface for message event

2b67bed

mayurkale22 added the feature-request label Nov 26, 2019

bg451 reviewed Nov 26, 2019

View reviewed changes

packages/opentelemetry-core/src/common/time.ts Show resolved Hide resolved

packages/opentelemetry-exporter-collector/src/CollectorExporter.ts Show resolved Hide resolved

chore: adding timestamp example

89ad47c

mayurkale22 approved these changes Nov 26, 2019

View reviewed changes

obecny added 2 commits November 26, 2019 21:29

chore: changes after review

c1ee7f6

chore: adding case when the exporter is shutdown but export is called

535d536

mayurkale22 added Target:Browser labels Nov 27, 2019

Flarna reviewed Nov 27, 2019

View reviewed changes

packages/opentelemetry-exporter-collector/src/platform/node/sendSpans.ts Show resolved Hide resolved

chore: adding missing header for request to prevent instrumentation

7849823

mayurkale22 added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Dec 1, 2019

Merge branch 'master' into collector-exporter

6859550

mayurkale22 requested review from bg451 and dyladan December 2, 2019 18:15

Merge branch 'master' into collector-exporter

0c2657d

bg451 approved these changes Dec 3, 2019

View reviewed changes

Merge branch 'master' into collector-exporter

b603098

vmarchaud approved these changes Dec 4, 2019

View reviewed changes

mayurkale22 merged commit b58ad10 into open-telemetry:master Dec 4, 2019

c24t mentioned this pull request Dec 20, 2019

Add OT collector trace exporter open-telemetry/opentelemetry-python#343

Closed

obecny deleted the collector-exporter branch February 2, 2021 17:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Collector exporter #552

Collector exporter #552

obecny commented Nov 20, 2019 •

edited

Loading

codecov-io commented Nov 20, 2019 •

edited

Loading

obecny commented Nov 20, 2019

mayurkale22 left a comment

mayurkale22 left a comment

draffensperger left a comment

draffensperger Nov 21, 2019

mayurkale22 Nov 25, 2019

mayurkale22 Nov 25, 2019

bg451 left a comment

mayurkale22 left a comment

mayurkale22 commented Dec 2, 2019

vmarchaud left a comment

Collector exporter #552

Collector exporter #552

Conversation

obecny commented Nov 20, 2019 • edited Loading

Which problem is this PR solving?

Short description of the changes

codecov-io commented Nov 20, 2019 • edited Loading

Codecov Report

obecny commented Nov 20, 2019

mayurkale22 left a comment

Choose a reason for hiding this comment

mayurkale22 left a comment

Choose a reason for hiding this comment

draffensperger left a comment

Choose a reason for hiding this comment

draffensperger Nov 21, 2019

Choose a reason for hiding this comment

mayurkale22 Nov 25, 2019

Choose a reason for hiding this comment

mayurkale22 Nov 25, 2019

Choose a reason for hiding this comment

bg451 left a comment

Choose a reason for hiding this comment

mayurkale22 left a comment

Choose a reason for hiding this comment

mayurkale22 commented Dec 2, 2019

vmarchaud left a comment

Choose a reason for hiding this comment

obecny commented Nov 20, 2019 •

edited

Loading

codecov-io commented Nov 20, 2019 •

edited

Loading