-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change loglevel for beta #856
Merged
mayurkale22
merged 3 commits into
open-telemetry:master
from
VilledeMontreal:feature/changes-loglocel-beta
Mar 13, 2020
Merged
fix: change loglevel for beta #856
mayurkale22
merged 3 commits into
open-telemetry:master
from
VilledeMontreal:feature/changes-loglocel-beta
Mar 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes open-telemetry#578 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
OlivierAlbertini
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
rochdev and
vmarchaud
as code owners
March 13, 2020 15:14
dyladan
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea I almost forgot we talked about this.
Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
mayurkale22
approved these changes
Mar 13, 2020
Please update the branch and we can merge |
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
==========================================
+ Coverage 92.62% 94.04% +1.41%
==========================================
Files 252 253 +1
Lines 11104 10997 -107
Branches 1064 1059 -5
==========================================
+ Hits 10285 10342 +57
+ Misses 819 655 -164
|
OlivierAlbertini
added
the
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
label
Mar 13, 2020
naseemkullah
pushed a commit
to naseemkullah/opentelemetry-js
that referenced
this pull request
Jul 24, 2020
As per open-telemetry#856 Signed-off-by: Naseem <naseem@transit.app>
naseemkullah
pushed a commit
to naseemkullah/opentelemetry-js
that referenced
this pull request
Jul 24, 2020
As per open-telemetry#856 Signed-off-by: Naseem <naseem@transit.app>
naseemkullah
pushed a commit
to naseemkullah/opentelemetry-js
that referenced
this pull request
Jul 25, 2020
User can now control the log level by means of env var. Sets default log level to INFO as per open-telemetry#856 Also shares mock environment functions for tests to be used in ConsoleLogger tests as well as environment tests. Signed-off-by: Naseem <naseem@transit.app>
naseemkullah
pushed a commit
to naseemkullah/opentelemetry-js
that referenced
this pull request
Jul 25, 2020
User can now control the log level by means of env var. Sets default log level to INFO as per open-telemetry#856 Also shares mock environment functions for tests to be used in ConsoleLogger tests as well as environment tests. Signed-off-by: Naseem <naseem@transit.app>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Amir Blum <amir@aspecto.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
LogLevel.INFO
instead ofLogLevel.DEBUG