Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change loglevel for beta #856

Merged
merged 3 commits into from
Mar 13, 2020
Merged

fix: change loglevel for beta #856

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ac1d32
fix: change loglevel for beta
OlivierAlbertini Mar 13, 2020
a39b66c
test: update to new default LogLevel
OlivierAlbertini Mar 13, 2020
7fdf94a
Merge branch 'master' into feature/changes-loglocel-beta
OlivierAlbertini Mar 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/opentelemetry-core/src/common/ConsoleLogger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { Logger } from '@opentelemetry/api';
import { LogLevel } from './types';

export class ConsoleLogger implements Logger {
constructor(level: LogLevel = LogLevel.DEBUG) {
constructor(level: LogLevel = LogLevel.INFO) {
if (level >= LogLevel.DEBUG) {
this.debug = (...args) => {
console.debug(...args);
Expand Down
2 changes: 0 additions & 2 deletions packages/opentelemetry-core/test/common/ConsoleLogger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ describe('ConsoleLogger', () => {
assert.deepStrictEqual(warnCalledArgs, ['warn called %s', 'param1']);
consoleLogger.info('info called %s', 'param1');
assert.deepStrictEqual(infoCalledArgs, ['info called %s', 'param1']);
consoleLogger.debug('debug called %s', 'param1');
assert.deepStrictEqual(debugCalledArgs, ['debug called %s', 'param1']);
});

it('should log with debug', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-metrics/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export interface MeterConfig {

/** Default Meter configuration. */
export const DEFAULT_CONFIG = {
logLevel: LogLevel.DEBUG,
logLevel: LogLevel.INFO,
};

/** The default metric creation options value. */
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-tracing/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const DEFAULT_MAX_LINKS_PER_SPAN = 32;
*/
export const DEFAULT_CONFIG = {
defaultAttributes: {},
logLevel: LogLevel.DEBUG,
logLevel: LogLevel.INFO,
sampler: ALWAYS_SAMPLER,
traceParams: {
numberOfAttributesPerSpan: DEFAULT_MAX_ATTRIBUTES_PER_SPAN,
Expand Down