Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reducer wrong example of enable-metrics and disable-metrics #281

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

letian0805
Copy link
Contributor

@letian0805 letian0805 commented Dec 13, 2024

Description:

The example of enable-metrics and disable-metrics is wrong. The command line prompts need to be separated by commas, but the example uses semicolons.
Link to tracking Issue:
#280
Testing:

Documentation:

Copy link

linux-foundation-easycla bot commented Dec 13, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Signed-off-by: letian0805 <letian0805@gmail.com>
@letian0805 letian0805 force-pushed the fix/reducer_config_example branch from a1f8fa4 to d571ab6 Compare December 13, 2024 07:57
Copy link
Contributor

@yonch yonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yonch
Copy link
Contributor

yonch commented Dec 13, 2024

Thank you @letian0805 ! Once CLA is signed, I'll be able to merge

@letian0805
Copy link
Contributor Author

@yonch CLA is signed.

@yonch yonch merged commit 3e8320f into open-telemetry:main Dec 16, 2024
1 check passed
@letian0805 letian0805 deleted the fix/reducer_config_example branch December 16, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants