Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reducer wrong example of enable-metrics and disable-metrics #281

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix reducer wrong example of enable-metrics and disable-metrics #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/reducer/reducer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
telemetry_port: 8000

# How many ingest shards to run.
num_aggregation_shards: 1
num_ingest_shards: 1

# How many matching shards to run.
num_matching_shards: 1
Expand Down Expand Up @@ -80,13 +80,13 @@ enable_percentile_latencies: false
# A metric group can also be disabled. To do so, specify '<group>.all', where <group> is one of: tcp,udp,dns,http.
# A value of 'none' can be given to enable all metrics.
# If this argument is not specified, the recommended collection of metrics will be used.
# Example: 'http.all;dns.all;udp.drops'. This will disable all http metrics, all dns metrics, and the udp.drops metric.
# Example: 'http.all,dns.all,udp.drops'. This will disable all http metrics, all dns metrics, and the udp.drops metric.
#disable_metrics: ""

# Comma-separated list of metrics to enable.
# This list is processed AFTER disable-metrics.
# A metric group can also be enabled. To do so, specify '<group>.all', where <group> is one of: tcp,udp,dns,http.
# Example: 'http.all;dns.all;udp.drops'. This will enable all http metrics, all dns metrics, and the udp.drops metric.
# Example: 'http.all,dns.all,udp.drops'. This will enable all http metrics, all dns metrics, and the udp.drops metric.
#enable_metrics: ""

# Interval (in seconds) to generate a JSON dump of the span indexes for each core.
Expand Down
4 changes: 2 additions & 2 deletions reducer/main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@ int main(int argc, char *argv[])
"A metric group can also be disabled. To do so, specify '<group>.all', where <group> is one of: tcp,udp,dns,http.\n"
"A value of 'none' can be given to enable all metrics.\n\n"
"If this argument is not specified, the recommended collection of metrics will be used.\n\n"
"Example: disable-metrics=http.all;dns.all;udp.drops\n"
"Example: disable-metrics=http.all,dns.all,udp.drops\n"
"This example will disable all http metrics, all dns metrics, and the udp.drops metric.",
{"disable-metrics"});

auto enable_metrics = parser.add_arg<std::string>(
"enable-metrics",
"A comma (,) separated list of metrics to enable. This list is processed AFTER disable-metrics\n"
"A metric group can also be enabled. To do so, specify '<group>.all', where <group> is one of: tcp,udp,dns,http.\n"
"Example: enable-metrics=http.all;dns.all;udp.drops\n"
"Example: enable-metrics=http.all,dns.all,udp.drops\n"
"This example will enable all http metrics, all dns metrics, and the udp.drops metric.",
{"enable-metrics"});

Expand Down