Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-adding removed trace attribute values #1368

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Aug 28, 2024

the MESSAGING_OPERATION_* attribute values were removed in semconv 1.26.0, so update our generation to put them back, marking as deprecated

the MESSAGING_OPERATION_* attribute values were removed in semconv 1.26.0,
so update our generation to put them back, marking as deprecated
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (653e453) to head (f16435b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1368      +/-   ##
============================================
+ Coverage     73.98%   74.01%   +0.03%     
  Complexity     2664     2664              
============================================
  Files           383      383              
  Lines          7634     7636       +2     
============================================
+ Hits           5648     5652       +4     
+ Misses         1986     1984       -2     
Flag Coverage Δ
8.1 73.73% <ø> (+0.06%) ⬆️
8.2 73.90% <ø> (ø)
8.3 73.95% <ø> (+0.01%) ⬆️
8.4 73.88% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653e453...f16435b. Read the comment docs.

@brettmc brettmc merged commit 4fc1700 into open-telemetry:main Aug 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants