Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-adding removed trace attribute values #1368

Merged
merged 3 commits into from
Aug 28, 2024
Merged

re-adding removed trace attribute values #1368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb258be
re-adding removed trace attribute values
brettmc Aug 28, 2024
28e0a08
add a note to also check values outputs for removals
brettmc Aug 28, 2024
f16435b
style
brettmc Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions script/semantic-conventions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ Use this output as a basis for updating the relevant deprecations file and gener
Note that some previously-removed semconv entries have been added back in recent versions, so may need to be removed from the
deprecations partials.

NB should also check `TraceAttributeValues` and `ResourceAttributeValues`, since those can also change.

## Add to SemConv/Version

Add an entry to `src/SemConv/Version.php` for the new version.
Expand Down
2 changes: 2 additions & 0 deletions script/semantic-conventions/templates/AttributeValues.php.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,7 @@ interface {{ class }}AttributeValues
{%- endif -%}
{% if not loop.last %}{# blank line #}{% endif %}
{%- endfor -%}
{# add our own deprecations for moved/removed values, so we don't break things #}
{% include class|lower + "_values_deprecations.php.partial" ignore missing without context %}
}
{# blank line #}
24 changes: 24 additions & 0 deletions script/semantic-conventions/templates/trace_values_deprecations.php.partial
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/**
* @deprecated Use `messaging.operation.type.publish`
*/
public const MESSAGING_OPERATION_PUBLISH = 'publish';

/**
* @deprecated Use `messaging.operation.type.create`
*/
public const MESSAGING_OPERATION_CREATE = 'create';

/**
* @deprecated Use `messaging.operation.type.receive`
*/
public const MESSAGING_OPERATION_RECEIVE = 'receive';

/**
* @deprecated Use `messaging.operation.type.deliver`
*/
public const MESSAGING_OPERATION_DELIVER = 'process';

/**
* @deprecated Use `messaging.operation.type.settle`
*/
public const MESSAGING_OPERATION_SETTLE = 'settle';
1 change: 1 addition & 0 deletions src/SemConv/ResourceAttributeValues.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,4 +487,5 @@ interface ResourceAttributeValues
* @see ResourceAttributes::TELEMETRY_SDK_LANGUAGE
*/
public const TELEMETRY_SDK_LANGUAGE_WEBJS = 'webjs';

}
25 changes: 25 additions & 0 deletions src/SemConv/TraceAttributeValues.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3144,4 +3144,29 @@ interface TraceAttributeValues
* @see TraceAttributes::VCS_REPOSITORY_REF_TYPE
*/
public const VCS_REPOSITORY_REF_TYPE_TAG = 'tag';

/**
* @deprecated Use `messaging.operation.type.publish`
*/
public const MESSAGING_OPERATION_PUBLISH = 'publish';

/**
* @deprecated Use `messaging.operation.type.create`
*/
public const MESSAGING_OPERATION_CREATE = 'create';

/**
* @deprecated Use `messaging.operation.type.receive`
*/
public const MESSAGING_OPERATION_RECEIVE = 'receive';

/**
* @deprecated Use `messaging.operation.type.deliver`
*/
public const MESSAGING_OPERATION_DELIVER = 'process';

/**
* @deprecated Use `messaging.operation.type.settle`
*/
public const MESSAGING_OPERATION_SETTLE = 'settle';
}
Loading