-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternative instrumentation abstraction #822
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
============================================
+ Coverage 81.52% 81.75% +0.22%
- Complexity 1925 1947 +22
============================================
Files 239 243 +4
Lines 5008 5069 +61
============================================
+ Hits 4083 4144 +61
Misses 925 925
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge this: SpanProcessor
s and MetricReader
s should run exports with the Context
they were created in.
use OpenTelemetry\Context\ScopeInterface; | ||
use Psr\Log\LoggerInterface; | ||
|
||
final class InstrumentationConfigurator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this implement ImplicitContextKeyedInterface
?
@Nevay happy for this to be merged? |
Should be ready after a rebase. |
Remove logs for now, will be replaced with `LoggerProvider` in the future.
cb9149e
to
d7c308d
Compare
Adds global (context-scoped) tracer provider & co, intended to replace the current
InstrumentationInterface
.