store logger in context, move LogsMessagesTrait into API #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove global/static LoggerHolder, and store logger in Context via Globals. LoggerHolder is deprecated, but a temporary BC hack should avoid immediate breakage.
Move LogsMessagesTrait into API, since there is a requirement (and some outstanding todo's) in the API layer to emit warnings in certain situations.
Closes #889