Skip to content

Commit

Permalink
Make field names uniform with type names (#126)
Browse files Browse the repository at this point in the history
Previously we had declarations like this:

  Int64Datapoints []*Int64DataPoint

The "Datapoints" and "DataPoint" portions use non-uniform cases.

Now we have:

  Int64DataPoints []*Int64DataPoint
  • Loading branch information
tigrannajaryan authored Mar 13, 2020
1 parent d496c80 commit 2e3afbf
Show file tree
Hide file tree
Showing 2 changed files with 73 additions and 73 deletions.
138 changes: 69 additions & 69 deletions gen/go/metrics/v1/metrics.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions opentelemetry/proto/metrics/v1/metrics.proto
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ message Metric {
// Data is a list of one or more DataPoints for a single metric. Only one of the
// following fields is used for the data, depending on the type of the metric defined
// by MetricDescriptor.type field.
repeated Int64DataPoint int64_datapoints = 2;
repeated DoubleDataPoint double_datapoints = 3;
repeated HistogramDataPoint histogram_datapoints = 4;
repeated SummaryDataPoint summary_datapoints = 5;
repeated Int64DataPoint int64_data_points = 2;
repeated DoubleDataPoint double_data_points = 3;
repeated HistogramDataPoint histogram_data_points = 4;
repeated SummaryDataPoint summary_data_points = 5;
}

// Defines a metric type and its schema.
Expand Down

0 comments on commit 2e3afbf

Please sign in to comment.