Make field names uniform with type names #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had declarations like this: Int64Datapoints []*Int64DataPoint The "Datapoints" and "DataPoint" portions use non-uniform cases. Now we have: Int64DataPoints []*Int64DataPoint
tigrannajaryan
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo and
yurishkuro
as code owners
bogdandrutu
approved these changes
Mar 13, 2020
MrAlias
pushed a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Mar 13, 2020
[Upstream changes](open-telemetry/opentelemetry-proto#126)
rghetia
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Mar 16, 2020
[Upstream changes](open-telemetry/opentelemetry-proto#126) Co-authored-by: Rahul Patel <rahulpa@google.com>
shbieng
added a commit
to shbieng/opentelemetry-go
that referenced
this pull request
Aug 26, 2022
[Upstream changes](open-telemetry/opentelemetry-proto#126) Co-authored-by: Rahul Patel <rahulpa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had declarations like this:
Int64Datapoints []*Int64DataPoint
The "Datapoints" and "DataPoint" portions use non-uniform cases.
Now we have:
Int64DataPoints []*Int64DataPoint