Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Travis CI #6

Closed
2 of 3 tasks
c24t opened this issue May 30, 2019 · 5 comments
Closed
2 of 3 tasks

Add Travis CI #6

c24t opened this issue May 30, 2019 · 5 comments
Labels
meta Related to repo itself, process, community, ...

Comments

@c24t
Copy link
Member

c24t commented May 30, 2019 •
edited
Loading

Configure travis to run (the as-yet unwritten) tests, lint, and coverage checks on each PR.

cc @lzchen, who did some related work in opencensus-python.

TODO:

  • run unit tests in API and SDK
  • lint and type checks
  • coverage check
@c24t c24t added the meta Related to repo itself, process, community, ... label May 30, 2019
This was referenced May 30, 2019
Closed
Closed
@mayurkale22 mayurkale22 mentioned this issue May 30, 2019
Closed
@c24t
Copy link
Member Author

c24t commented Jun 4, 2019

We should consider adding pylint here as per census-instrumentation/opencensus-python#667 (comment).

@bogdandrutu
Copy link
Member

yaay, we will have lint :)

@c24t
Copy link
Member Author

c24t commented Jun 5, 2019

CI should also type check the API modules as e.g.

mypy --disallow-untyped-defs --disallow-untyped-decorators opentelemetry/api

Oberon00 added a commit to dynatrace-oss-contrib/opentelemetry-python that referenced this issue Jun 24, 2019
@Oberon00
Add .pylintrc based on OpenCensus (related open-telemetry#6).
67be139
Oberon00 added a commit that referenced this issue Jun 25, 2019
@Oberon00
Add a .pylintrc & fix warnings (#24)
5d1632a 
* Add .pylintrc based on OpenCensus (related #6).

* Fix/disable pylint warnings.

* pylint: Fix W0107: Unnecessary pass statement (unnecessary-pass)

I'm not sure I like this warning.
@c24t c24t mentioned this issue Jun 26, 2019
Merged
@Jamim
Copy link
Contributor

Jamim commented Sep 5, 2019

I'm going to create a PR that addresses coverage check point.

What service would you like to use for coverage collecting?
I personally prefer https://codecov.io, but I want to know what service you want to integrate with.

@mauriciovasquezbernal
Copy link
Member

Coverage PR: #128

@c24t c24t closed this as completed Oct 31, 2019
codeboten pushed a commit that referenced this issue Jul 21, 2020
@sartx
Merge pull request #6 from open-telemetry/master
df2e8e2 
update branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Related to repo itself, process, community, ...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bogdandrutu @Jamim @mauriciovasquezbernal @c24t