Add a .pylintrc & fix warnings #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Jun 24, 2019
carlosalberto
approved these changes
Jun 24, 2019
c24t
approved these changes
Jun 24, 2019
| @@ -68,7 +68,7 @@ | |||
| from typing import Iterator | |||
|
|
|||
|
|
|||
| class Tracer(object): | |||
| class Tracer: | |||
There was a problem hiding this comment.
FYI there's a subtle difference here. The old version lets you monkey patch builtins.object: https://stackoverflow.com/a/45893772. But that seems like a feature we're better off without...
👍 to losing |
Merged
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on opencensus/opencensus-python#667, with one major difference: I emptied the
disabledchecks and only re-disabled a few select ones. I also commented out a few settings that I believe were equal to the default anyway. Of course, I also fixed the issues pylint already found and added a dev-requirements.txt that can be used to install the right pylint version.One thing I'm not sure about is the "W0107: Unnecessary pass statement (unnecessary-pass)" warning. When a function has a docstring, the pass-statement is not required anymore but I guess you could argue that the resulting code is odd. Still, it removes a few lines so I heeded the warning for now. What do you think?