Skip to content

Conversation

@arielvalentin
Copy link
Contributor

@arielvalentin arielvalentin commented Oct 11, 2022

A change in ruby@3.1, rubygems, and/or bundler@2.3.23 is preventing native extensions both sqlite3 and nokogiri on Windows.

I tried a few different incantations to force bundler to load platform specific versions of x64-mingw-ucrt, however all attempts fell short in some way.

Locking the bundler version to 2.3.22 was the only way I could get the native extensions to install.

This is a temporary fix until we can figure out what changed in the bundler ecosystem to cause this issue.

cc: @johnnyshields

A change in `ruby@3.1`, `rubygems`, and/or `bundler@2.3.23` is preventing native extensions both `sqlite3` and `nokogiri` on Windows.

I tried a few different incantations to force bundler to load platform specific versions of [`x64-mingw-ucrt`](open-telemetry#138),
however all attempts fell short in some way.

Locking the bundler version to 2.3.22 was the only way I could get the native extensions to install.

This is a temporary fix until we can figure out what changed in the bundler ecosystem to cause this issue.
@arielvalentin arielvalentin merged commit 8ca60ce into open-telemetry:main Oct 11, 2022
@arielvalentin arielvalentin deleted the downgrade-bundler branch October 11, 2022 16:38
@johnnyshields
Copy link
Contributor

johnnyshields commented Oct 11, 2022

@arielvalentin can you point me to the original test run that's failing and the error you are seeing? We did some Windows-related changes to Bundler in order to support Windows Ruby 3.1. Those changes should be entirely backwards compatible, so I'm surprised there are any issues here.

@johnnyshields
Copy link
Contributor

@deivid-rodriguez

@johnnyshields
Copy link
Contributor

johnnyshields commented Oct 11, 2022

@arielvalentin I'm looking at the diff of ruby/rubygems@v3.3.22...v3.3.23

All my windows PRs were already released in v3.3.22 (which is the non-buggy version to which you've reverted) so I think the issue must be something unrelated to my changes.

This line in the diff looks suspect given the errors above:
ruby/rubygems@v3.3.22...v3.3.23#diff-1a57f160581a91a058c82b5d67dbba3cae6653a38529599911b0e4b0f0db9087R66

NoMethodError: undefined method `full_name' for nil:NilClass

  warning << "* #{unmet_spec_dependency}, depended upon #{spec.full_name}, unsatisfied by #{@specs.find {|s| s.name == unmet_spec_dependency.name && !unmet_spec_dependency.matches_spec?(s.spec) }.full_name}"

@deivid-rodriguez

@johnnyshields
Copy link
Contributor

@arielvalentin recommend you to raise an issue with Rubygems.

@deivid-rodriguez
Copy link

Hi, it has already been raised several times, I kept this one opened: ruby/rubygems#5970. There's already a fix proposed at ruby/rubygems#5975. I recommend to stick to 2.3.22 until I release that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants