Fix incorrect materialization on Windows #5975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
windows-fix
branch
from
83a29f9 to
a8ad8a5
Compare
I didn't realize how the `Bundler::GemHelpers.generic` method works when I added this. It already matches this and other java platforms properly.
deivid-rodriguez
force-pushed
the
windows-fix
branch
from
a8ad8a5 to
ab11545
Compare
It was using the originally given platform. It's the same as the real gemspec platform, but in some edge cases it could be different.
|
Thank you for fixing this @deivid-rodriguez Do you know when this might get merged and released? Trying to decide whether to wait or pin back to an older version. |
Contributor
Author
|
Normally I would release new versions next Wednesday, but this particular bug has broken very basic usages on Windows, so I'm considering an earlier release. I can't promise anything though, so if next Wednesday is too late for you I suggest pinning. |
This comment was marked as resolved.
This comment was marked as resolved.
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 17, 2022
Fix incorrect materialization on Windows (cherry picked from commit 2428fb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I did some cleanups recently to avoid unnecessary sorting and speed things up at #5868. But one change in particular caused issues on Windows.
What is your fix for the problem, implemented in this PR?
I identified this code here: https://github.com/rubygems/rubygems/blob/629e08d34d14f60fe3398e40fc72f4f171ffc582/bundler/lib/bundler/lazy_specification.rb#L82-L84 was relying on the index search returning a particular order.
I think we'll probably need to revert that commit but I also found that this code should not be being hit by default on Windows, since it's only a fallback for backwards compatibility with lockfiles using
rubyorjavaas their main platform, and that's not the case on Windows.This commit fixes that latter issue and adds a realworld CI test that installs Rails and generates a dummy application on Windows, to hopefully avoid this kind of widespread issues on Windows in the future.
Fixes #5970.
Make sure the following tasks are checked