Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Named Tracers and Meters" #113

Closed
z1c0 opened this issue Oct 4, 2019 · 5 comments
Closed

Implement "Named Tracers and Meters" #113

z1c0 opened this issue Oct 4, 2019 · 5 comments
Assignees
Milestone

Comments

@z1c0
Copy link

z1c0 commented Oct 4, 2019

The "Named Tracers and Meters" RFC (https://github.com/open-telemetry/oteps/blob/master/text/0016-named-tracers.md) has been approved and was added to the specification (open-telemetry/opentelemetry-specification#264).

Please make sure to also update the documentation if necessary (tracer, meter creation).

OpenTelemetry language repositories now need to implement this mechanisms.

@fbogsany
Copy link
Contributor

fbogsany commented Oct 4, 2019

TBH, based on my reading of the spec, I have no idea of how to either implement or use this mechanism. I'd ask for clarification, but I don't know where to start 😞.

@z1c0
Copy link
Author

z1c0 commented Oct 8, 2019

Heres the OTEP/RFC that was the basis for the changes in the specification:
https://github.com/open-telemetry/oteps/blob/master/text/0016-named-tracers.md
Maybe this one clear that up a little bit.

Also, the PR for named tracers in .NET might help:
open-telemetry/opentelemetry-dotnet#239

@fbogsany
Copy link
Contributor

fbogsany commented Oct 8, 2019

I read the OTEP. It didn't help. Specifically, the motivation seemed weak and the extra complexity doesn't seem justified. I think the intent is to build additional functionality on top of this, but that functionality isn't spelled out in the OTEP, so it's a little too opaque. Some code examples (in the OTEP) for instrumentation and application authors might have gone a long way to improving clarity.

@louy2
Copy link

louy2 commented Oct 13, 2019

Instrumentation libraries can easily "spam" backend systems, deliver bogus data or - in the worst case - crash or slow down applications.

This sentence in the OTEP reminds me of when systemd spammed kernel log on debug (FreeDesktop Bug 76935). Linux kernel ended up gaining an option to prevent all user-space applications from writing to the kernel log, akin to "a Sampler [...] that discards Spans or Metrics from certain libraries".

@fbogsany fbogsany self-assigned this Oct 23, 2019
@mwear mwear added this to the Alpha v0.2 milestone Oct 23, 2019
@fbogsany
Copy link
Contributor

fbogsany commented Nov 4, 2019

This is done, at least the API side and the tracing part of the SDK. We don't have a SDK spec for metrics yet.

@fbogsany fbogsany closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants