Named tracers #239
Merged
Named tracers #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync repository
LoggingTracer now prints "LibraryResource" information (name + version) Make "LibraryResource" available on Spans.
z1c0
requested review from
austinlparker,
discostu105,
lmolkova and
SergeyKanzhelev
as code owners
lmolkova
reviewed
Oct 1, 2019
src/OpenTelemetry.Collector.AspNetCore/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Collector.Dependencies/AzureSdkDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
LoggingTracer now prints "LibraryResource" information (name + version) Make "LibraryResource" available on Spans.
lmolkova
reviewed
Oct 2, 2019
lmolkova
reviewed
Oct 2, 2019
lmolkova
reviewed
Oct 2, 2019
lmolkova
approved these changes
Oct 2, 2019
Co-Authored-By: Liudmila Molkova <lmolkova@microsoft.com>
|
Since the specification for "Named Tracers" is now final and accepted (open-telemetry/opentelemetry-specification#264), I think this is ready to merge? |
This was referenced Oct 4, 2019
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
* Update CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the "Tracer" part of #237 and the underlying spec change due to https://github.com/open-telemetry/oteps/blob/master/text/0016-named-tracers.md