Named Tracers and Meters #264
Conversation
…ce-oss-contrib/opentelemetry-specification into named-tracers-and-meters
z1c0
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
|
Related:
|
| New `Meter` instances can be created via a `MeterFactory` and its `getMeter` | ||
| method. This method expects two string arguments: | ||
|
|
||
| - `name` (required): This name must identify the instrumentation library (also |
There was a problem hiding this comment.
I think it would be good to split this into 2 different strings:
- integration path -
io.opentelemetry.contrib - instrumented library (component name) -
mongodb
This way we can use the instrumented library name, and get rid of the component attribute in the Span. No need to have that set for every Span/Metric we create from this Tracer/Meter.
This may be done in a separate PR but want to hear opinions.
There was a problem hiding this comment.
I agree we should do it in separate PR. This PR doesn't tell how this name will be used except to disable certain component's telemetry
There was a problem hiding this comment.
Yeah, I think this PR should just implement the OTEP and not go beyond it.
|
@yurishkuro any more feedback on this PR? beyond #272 all other comments seems to be addressed. We need 1 more sign off here |
|
In the lack of responses and since the OTEP was already approved for this, merging... Topic starter and two approvers are all from different companies |
* Extended spec with "Named Tracers/Meters" concept. * Implement feedback about wording. * Restore the "runtimes with multiple deployments paragraph" * Update documentation about the "name" argument in Tracer/Meter creation. * Implement PR feedback
Extend the specification regarding Tracer and Meter creation based on the OTEP "Named Tracers And Meters" (https://github.com/open-telemetry/oteps/blob/master/text/0016-named-tracers.md)
Fixes #273