Sync repository #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET 4.7.2 was superseded by 4.8. There was no 4.7.3.
* Don't await task if unused * Supress exception at the API entry
* .editorconfig defines to use var
…s quick guide in readme (open-telemetry#123) * Changed open census to OpenTelemetry in readme file * Added + wildcard, updated sample and readme to reflect sample
* first metrics * added metrics * implement default meter * measures * adderssed code review * adderssed code review * pascal case for enum
* reordered all usings (SA1208) * Use trailing comma in multi-line initializers (SA1413) * SA1005 Single line comment should begin with a space. * SA1028 Code should not contain trailing whitespace * A1101 Prefix local calls with this * SA1500 Braces for multi-line statements should not share line * SA1505 An opening brace should not be followed by a blank line. * SA1513 Closing brace should be followed by blank line * SA1517 Code should not contain blank lines at start of file * A1507 Code should not contain multiple blank lines in a row * SA1503 Braces should not be omitted * SA1508 A closing brace should not be preceded by a blank line * SA1210 Using directives should be ordered alphabetically by the namespaces * IDE0065 Removed unnecessary usings * SA1633 The file header is missing or not located at the top of the file. * IDE0044 Make field readonly * SA1311 Static readonly fields should begin with upper-case letter * IDE0060 Remove unused parameter 'options' if it is not part of a shipped public API * various IDE warnings cleaned up * SA1400 Element should declare an access modifier * SA1402 File may only contain a single type * SA1638 File header file name documentation should match file name * SA1629 Documentation text should end with a period * various code uncommon style warnings fixes * SA1137 Elements should have the same indentation * SA1648 inheritdoc should be used with inheriting class * SA1616 Element return value documentation should have text * SA1310 Field should not contain an underscore * Various documentation rule violations fixed * SA1614 Element parameter documentation should have text * SA1137 Elements should have the same indentation * Various documentation rule violations fixed * CS1574 XML comment has cref attribute that could not be resolved * CS1572 XML comment has a param tag for, but there is no parameter by that name * SA1204 Static members should appear before non-static members * SA1201 A property should not follow a method * SA1201 A constructor should not follow a property * SA1202 'public' members should come before 'private' members * SA1202 'internal' members should come before 'private' members * SA1202 'protected' members should come before 'private' members * CS0168 The variable 'ex' is declared but never used * Moved to implicit version resolution, as stated in the warning from the dotnet sdk * various cleanups and project structure * CS1591 disabled for the entire solution * removed `[assembly: System.CLSCompliant(true)]` from contributed projects * Fixed various async snafus. * removed version.props from proj file * enabled TreatWarningsAsErrors
* Align with spec on ISpanBuilder and ITraces * add bad args tests on SpanBuilder
* Rmoving ITraceComponent and TraceComponent * Removing ITagsComponent, TagsComponentBase and TagsComponent * REmoving ITagPropagationComponent, TagPropagationComponentBase and TagPropagationComponent * Removing IStatsComponent, StatsComponentBase and StatsComponent * Addressing test failures since updates have allowed rules on duplicates to be enforced. * Test updates, wrok in progress * Resolving some unit test failrues * Resolving some unit test failrues * Simplify map to list * Addressing final set of unit test failures * Updating for feedback * Addressing tests that were relying on specific order * Updating for feedback * Addressing merge issues * Resolving build and test failures introduced in merge * Resolving additional build and test issues * Fixing unresolved dependencies
* refactor AttributeType to KeyValuePair
* StartSpanWithActivity * Sampler builder tests * cleanup start span * span tests * optimize tracestate * public tracestate parsing * more tracestate tests * Scopes and scope tests * minor merge issues * Do not make Span's Activity Current until WithSpan is called * CurrentSpanUtils to static * Tracestate parsing is not public API, reuse code without exposing it * more tests and fixes * rename * rename FromCurrentActivity to SetCreateChild * fix rebase issues * fix build warning * undo separate test project for Abstractions.Tests to fix build * up
* remove remains of AttributeVakue * fix tests * fix tests
* Remove IAttributes and change Dictionary to list * Optimize AtributesWithcapacity to use linked list instead of ordered disct and reduce copying
* Remove timestamp * Remove timestamp, remove Timer, remove Duration. remove Span Stores, remove EndSpanOptions and EndSpanOptionsBuilder * remove collections * clean up more collections and span name * missing files * dups * rebase issues
…ng string literals with nameof(). (open-telemetry#157)
* move and rename "Samples" project to "samples\Exporters" * add "LoggingTracer" as an example of an API implementation * add readme to solution file * remove Samples project from solution * fix scoping * add "LoggingTracer" as an example of an API implementation * add readme to solution file * fix scoping * changed back to 2.1. was an accidental change. * added "Demo" to project names * adapted LoggingTracer to API changes. stripped down asp.net core example to bare minimum. * cleaned up LoggingTracer sample. not more NotImplementedExceptions, adhere to code style better (usings), don't log getters * consistency fixes * made console sample async, code style * adapt to API changes
* Fix visual studio dotnet core build task * Added CNCF Jaeger exporter support open-telemetry#77 * possible fix for win32 build issue. * Fix windows build by adding Thrift source * Fix yet more windows build issues. * fix another style issue. * fix reference to System.Net.Http * remove unnecessary conditional framework reference. * Update lib/Thrift/Transports/Client/TStreamClientTransport.cs Co-Authored-By: Bruno Garcia <github@brunogarcia.com> * Update lib/Thrift/Transports/Client/TStreamClientTransport.cs Co-Authored-By: Bruno Garcia <github@brunogarcia.com> * Added the conditional for netstandard2.0 * remove IDisposable TODO comments. * Update src/OpenTelemetry.Exporter.Jaeger/Implimentation/EmitBatchArgs.cs Co-Authored-By: Bruno Garcia <github@brunogarcia.com> * Add readme with thrift fork info. * cleanup after merge. * WIP remove thrift code * Use prepackaged Apache Thrift assembly * wrap EmitBatch * Revert "wrap EmitBatch " This reverts commit 9aaa138. * Revert "Use prepackaged Apache Thrift assembly" This reverts commit fa5fbd8. * Revert "Use prepackaged Apache Thrift assembly" This reverts commit fa5fbd8. * Revert "WIP remove thrift code" This reverts commit bbbcf47. * Add missing ConfigureAwait(false) to Thrift async calls. * Added Thrift fork differences to README.md * WIP Jaeger Unit tests * Fix build after merge. * WIP Jaeger Unit tests - Span conversion to Jaeger Thrift format * WIP Jaeger Unit tests - Span conversion to Jaeger Thrift format - cleanup * Clean up merge issues * WIP * WIP cleanup * more testing WIP * use pattern matching for attribute conversion * WIP cleanup after timestamp removal. * WIP * WIP UDP integration test * Update src/OpenTelemetry.Exporter.Jaeger/Implimentation/Batch.cs Co-Authored-By: Bruno Garcia <github@brunogarcia.com> * remove solution-explorer * add to gitignore * refactored List<T> to IEnumerable<T> * Fix unit test bug * Add integration test * cleanup * fix unix epoch conversion * Update Thrift expected payload in unit test. * fix build issues * fix typo * fix solution
* review use of lists * Use Enumerable.Empty * Remove alloc of empty array
* build all targets in all platforms Resolves open-telemetry#154 * Tests for netfx run only on Windows * AppInsights can build x-plat * fix: TFMs for Jaeger
* Removing ExportComponent * Updating IExportComponent references * Updating references to ExportComponent
…y#167) * Do not export calls to Zipkin * up
* Add Azure collector * Url as the name * Full * Comments * More feedback * More * Start with OK span * fb * FB * undo * Http
…pen-telemetry#178) * Multiple calls to DiagnosticSourceSubscriber::Dispose would throw nullrefs. All Dispose methods should be idempotent. - Switched the dispose flag check(s) from using Volatile to using Interlocked.CompareExchange and Interlocked.Read - Add null checks to the arguments - Added a simple unit test class for this internal class * Wrap InternalVisibleTo in a #if SIGNED preprocessor block * Applying the same Dispose pattern to DiagnosticSourceSubscriber in the Collector.Dependencies assembly
…cies EventSource (open-telemetry#181) Verified provider events using PerfView
discostu105
approved these changes
Aug 12, 2019
discostu105
approved these changes
Aug 12, 2019
Oberon00
pushed a commit
that referenced
this pull request
Dec 30, 2020
* Picking up where alexvaluyskiy left off with the SqlClientCollector. Worked on PR feedback. Added unit tests. * Updated README. * Fixed inconsistent comments. * Code review. * Code review #2. * More code review. * Code review feedback. Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Oberon00
pushed a commit
that referenced
this pull request
Dec 30, 2020
* Document HTTP instrumentation options * Clarify HttpClient vs. HttpWebRequest instrumentation * Remove section about adding HttpClient vs. HttpWebRequest instrumentation * Update documentation on Enrich option Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
joaopgrassi
pushed a commit
that referenced
this pull request
Oct 7, 2021
…rom native to managed threads (open-telemetry#2314) * WIP working on reproducing and fixing lost baggage. * TelemetryHttpModule now restores Baggage. * Updated public api. * Unit tests. * Use SuppressFlow for more accurate test. * CHANGELOG update. * Attempting to fix unstable test. * Attempting to fix unstable test #2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from "opentelemetry-dotnet".