Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aws id generator from core sdk #1489

Closed
cijothomas opened this issue Jan 24, 2024 · 4 comments · Fixed by #1820
Closed

Remove aws id generator from core sdk #1489

cijothomas opened this issue Jan 24, 2024 · 4 comments · Fixed by #1820
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers/approvers
Milestone
Tracing SDK Stable

Comments

@cijothomas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/trace/id_generator/aws.rs must be moved to contrib crate and should not be part of core sdk.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#id-generators
@cijothomas cijothomas added good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers/approvers labels Jan 24, 2024
@cijothomas cijothomas added this to the Tracing SDK Stable milestone Feb 1, 2024
@sreeo sreeo mentioned this issue Feb 9, 2024
Merged
4 tasks
@sreeo
Copy link
Contributor

sreeo commented Feb 20, 2024

how do we proceed with the removal from the core repo? Do we add a deprecated message/warning and release a version?

@cijothomas
Copy link
Member Author

#1560 You can copy some of the ideas from this PR. (That PR removes an entire crate, but this is just a functionality, so adjust wordings accordingly.)

@sreeo sreeo mentioned this issue Feb 23, 2024
Merged
4 tasks
hdost pushed a commit that referenced this issue Feb 24, 2024
@sreeo
Deprecate AWS XrayIdGenerator (#1573)
27cf653 
Deprecates the XrayIdGenerator in the opentelemetry core sdk.

Now available in opentelemetry-aws
Relates #1489
@sreeo
Copy link
Contributor

sreeo commented Mar 18, 2024

Would this be the right time to raise a PR where the XrayIdGenerator is removed from the core repo? Or do we wait for a few releases?

@cijothomas cijothomas mentioned this issue May 24, 2024
Merged
@cijothomas
Copy link
Member Author

Would this be the right time to raise a PR where the XrayIdGenerator is removed from the core repo? Or do we wait for a few releases?

Hey sorry I missed this message until now! It should be removed now : #1820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers/approvers
Projects
None yet
Milestone
Tracing SDK Stable
Development

Successfully merging a pull request may close this issue.

Remove AWSid generator cijothomas/opentelemetry-rust
2 participants
@sreeo @cijothomas