deprecation(opentelemetry-jaeger): Add deprecation notice. #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdost
force-pushed
the
chore/995-add-deprecation-notices
branch
3 times, most recently
from
5a4a6f2 to
c9a6ff9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1560 +/- ##
=====================================
Coverage 66.0% 66.0%
=====================================
Files 140 140
Lines 19537 19537
=====================================
Hits 12903 12903
Misses 6634 6634 ☔ View full report in Codecov by Sentry. |
- Add deprecation flags to the various components to give notices in users compilers. - Add more definition around the deprecation in the README. - Add a deprecation badge for crates.io. - Update changelog to show deprecation notice. Relates open-telemetry#995
hdost
force-pushed
the
chore/995-add-deprecation-notices
branch
from
c9a6ff9 to
e7f1db2
Compare
TommyCpp
reviewed
Feb 19, 2024
| // make sure when collector_cilent and wasm_collector_client are both set. We will create a wasm type client | ||
| #[deprecated( | ||
| since = "0.21.0", | ||
| note = "Please Migrate to opentelemetry-otlp exporter." |
There was a problem hiding this comment.
wasm is not available for now. We probably will have to stablize the existing API before explore the wasm support
There was a problem hiding this comment.
So is this the reason people are still using Jaeger? if it's WASM then that seems like a blocker to me.
There was a problem hiding this comment.
It could be? But crates.io doesn't provide feature level metrics so it's hard to say for sure.
TommyCpp
approved these changes
Feb 19, 2024
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
cijothomas
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #995