Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating opentelemetry-jaeger #995

Closed
cijothomas opened this issue Mar 13, 2023 · 10 comments · Fixed by #1022 or #1782
Closed

Deprecating opentelemetry-jaeger #995

cijothomas opened this issue Mar 13, 2023 · 10 comments · Fixed by #1022 or #1782
Labels
A-trace Area: issues related to tracing help wanted Good for taking. Extra help will be provided by maintainers/approvers

Comments

@cijothomas
Copy link
Member

The current project for OpenTelemetry jaeger (https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-jaeger) seems to be doing 2 things:

  1. Jaeger propagator
  2. Jaeger exporter.

Proposing to do:

  1. Given the Jaeger exporter is slated to be deprecated (Deprecate jaeger exporters. opentelemetry-specification#2858), proposing to remove the Jaeger exporter from this, and instead advice users to move to OTLP.

  2. The spec recommends Jaeger propagator to be shipped as an extension package (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md#propagators-distribution).
    Once the exporter is removed, this package/crate can be renamed to reflect its actual purpose, which would be just the propagator. (a name change might also be needed)
@TommyCpp TommyCpp added the A-trace Area: issues related to tracing label Mar 13, 2023
@TommyCpp
Copy link
Contributor

Some context here: Jaeger and OTLP create are two most popular creates we have. I think we can mark jaeger exporter as deprecated going forward but may need to give users sometime to switch to OTLP. We also need some documents and examples around how to swich.

@cijothomas
Copy link
Member Author

We also need some documents and examples around how to switch.

Adding a PR showing that for reference, if needed in this SIG : https://github.com/open-telemetry/opentelemetry-dotnet/pull/3940/files
It also shows it was very straightforward to make the switch.

@cijothomas cijothomas mentioned this issue Mar 14, 2023
Merged
@DontBreakAlex
Copy link

DontBreakAlex commented Apr 11, 2023 •
edited
Loading

The actix examples still use the jeager exporter, so there are no example showing how to use the recommended otlp exporters with actix or hyper.

@cijothomas
Copy link
Member Author

The actix examples still use the jeager, so there are no example showing how to use the recommended otlp exporters with actix or hyper.

Yes. This was discussed in today's SIG meeting. I'll be sending PR to update example to use OTLP Exporter for Jaeger.

@cijothomas cijothomas mentioned this issue Apr 11, 2023
Merged
@hdost hdost linked a pull request Apr 14, 2023 that will close this issue
Modify Actix example to use OTLP ingestion for Jaeger #1022
Merged
@cijothomas cijothomas reopened this Aug 9, 2023
@cijothomas
Copy link
Member Author

https://github.com/open-telemetry/opentelemetry-specification/pull/3567/files Spec has removed Jaeger exporter specs. Most other languages have removed. I'll start the clean up in this repo.

@cijothomas cijothomas self-assigned this Oct 3, 2023
@cijothomas cijothomas mentioned this issue Oct 3, 2023
Closed
@BrynCooke BrynCooke mentioned this issue Oct 3, 2023
Open
28 tasks
@cijothomas cijothomas mentioned this issue Oct 19, 2023
Closed
@cijothomas cijothomas added the help wanted Good for taking. Extra help will be provided by maintainers/approvers label Oct 19, 2023
@cijothomas
Copy link
Member Author

Tagging with help-wanted if anyone willing to contribute!

This was referenced Nov 1, 2023
Merged
Merged
@cijothomas cijothomas mentioned this issue Nov 22, 2023
Merged
4 tasks
@cijothomas
Copy link
Member Author

The next step would be to create a separate crate for the propagator alone, "opentelemetry-propagator-jaeger", extracting the propagation part from opentelemetry-jaeger crate.

@mattbodd
Copy link
Contributor

@cijothomas I'd be interested in taking on this work

@cijothomas cijothomas assigned mattbodd and unassigned cijothomas Jan 19, 2024
@cijothomas
Copy link
Member Author

cijothomas commented Jan 19, 2024 •
edited
Loading

@cijothomas I'd be interested in taking on this work

Thanks! #995 (comment) lists the next step to be followed, and after that, we can work towards deprecating the current one. Feel free to explore/share any alternate ways of handling the deprecation in a smooth way!

@mattbodd mattbodd mentioned this issue Jan 23, 2024
Merged
4 tasks
hdost added a commit to hdost/opentelemetry-rust that referenced this issue Feb 18, 2024
@hdost
deprecation(opentelemetry-jaeger): Add deprecation notice.
e2785a3 
- Add deprecation flags to the various components to give notices in
  users compilers.
- Add more definition around the deprecation in the README.
- Add a deprecation badge for crates.io.

Relates open-telemetry#995
@hdost hdost mentioned this issue Feb 18, 2024
Merged
hdost added a commit to hdost/opentelemetry-rust that referenced this issue Feb 18, 2024
@hdost
deprecation(opentelemetry-jaeger): Add deprecation notice.
94c2a2a 
- Add deprecation flags to the various components to give notices in
  users compilers.
- Add more definition around the deprecation in the README.
- Add a deprecation badge for crates.io.
- Update changelog to show deprecation notice.

Relates open-telemetry#995
hdost added a commit to hdost/opentelemetry-rust that referenced this issue Feb 18, 2024
@hdost
deprecation(opentelemetry-jaeger): Add deprecation notice.
5a4a6f2 
- Add deprecation flags to the various components to give notices in
  users compilers.
- Add more definition around the deprecation in the README.
- Add a deprecation badge for crates.io.
- Update changelog to show deprecation notice.

Relates open-telemetry#995
hdost added a commit to hdost/opentelemetry-rust that referenced this issue Feb 18, 2024
@hdost
deprecation(opentelemetry-jaeger): Add deprecation notice.
c9a6ff9 
- Add deprecation flags to the various components to give notices in
  users compilers.
- Add more definition around the deprecation in the README.
- Add a deprecation badge for crates.io.
- Update changelog to show deprecation notice.

Relates open-telemetry#995
hdost added a commit to hdost/opentelemetry-rust that referenced this issue Feb 19, 2024
@hdost
deprecation(opentelemetry-jaeger): Add deprecation notice.
e7f1db2 
- Add deprecation flags to the various components to give notices in
  users compilers.
- Add more definition around the deprecation in the README.
- Add a deprecation badge for crates.io.
- Update changelog to show deprecation notice.

Relates open-telemetry#995
@hdost hdost mentioned this issue Feb 19, 2024
Merged
hdost added a commit that referenced this issue Feb 19, 2024
@hdost
deprecation(opentelemetry-jaeger): Add deprecation notice. (#1560)
36c2a8e 
- Add deprecation flags to the various components to give notices in users compilers.
- Add more definition around the deprecation in the README.
- Add a deprecation badge for crates.io.

Relates #995
@hdost hdost changed the title Consider deprecating opentelemetry-jaeger Deprecating opentelemetry-jaeger Feb 19, 2024
@hdost
Copy link
Contributor

hdost commented Feb 19, 2024

Commit has been merged to prepare release 0.21.0 as the first deprecated release.
Notice prominent on the README and deprecation marker has been placed on objects to give users notice.

Currently 0.22.0 will be the last release.

I think depending on the feedback we get from users this may change. Something brought up by @TommyCpp is that we don't currently have testing for WASM on OTLP, and we can't know exactly why people are using the jaeger exporter yet.

@hdost hdost mentioned this issue Feb 21, 2024
Closed
hdost added a commit to hdost/poem that referenced this issue Feb 26, 2024
@hdost
Update opentelemetry-jaeger to use OTLP
89a20cb 
Jaeger has been compatibile with OTLP for over 2 years. We want to
encourage usage of OTLP exporter.

open-telemetry/opentelemetry-rust#995
@hdost hdost mentioned this issue Feb 26, 2024
Merged
hdost added a commit to hdost/poem that referenced this issue Feb 28, 2024
@hdost
Update opentelemetry-jaeger to use OTLP
0f03c17 
Jaeger has been compatibile with OTLP for over 2 years. We want to
encourage usage of OTLP exporter.

open-telemetry/opentelemetry-rust#995
sunli829 pushed a commit to poem-web/poem that referenced this issue Mar 2, 2024
@hdost
Update opentelemetry-jaeger to use OTLP (#761)
563a6b7 
Jaeger has been compatibile with OTLP for over 2 years. We want to
encourage usage of OTLP exporter.

open-telemetry/opentelemetry-rust#995
@tnewman tnewman mentioned this issue Mar 2, 2024
Closed
@cijothomas cijothomas mentioned this issue Mar 17, 2024
Closed
@cijothomas cijothomas mentioned this issue May 18, 2024
Merged
azurelotus0926 added a commit to azurelotus0926/poem that referenced this issue Jun 27, 2024
@azurelotus0926
Update opentelemetry-jaeger to use OTLP (#761)
36ada91 
Jaeger has been compatibile with OTLP for over 2 years. We want to
encourage usage of OTLP exporter.

open-telemetry/opentelemetry-rust#995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-trace Area: issues related to tracing help wanted Good for taking. Extra help will be provided by maintainers/approvers
Projects
None yet
Milestone
No milestone
5 participants
@hdost @cijothomas @TommyCpp @mattbodd @DontBreakAlex