Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Actix example to use OTLP ingestion for Jaeger #1022

Merged
merged 8 commits into from
Apr 20, 2023

Conversation

cijothomas
Copy link
Member

Related to this : #995
This PR modifies the Actix-Http example to use OTLP Exporter instead of Jaeger Exporter. The name of the project is still "actix-http".

There are quite a few examples with actix showing http/hyper/udp. It could be consolidated to a single one. If there is a desire to consolidate, I can propose a PR for that separately.

@cijothomas cijothomas requested a review from a team April 11, 2023 20:08
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 5.9% and project coverage change: -0.9 ⚠️

Comparison is base (3597479) 57.2% compared to head (96747f6) 56.4%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1022     +/-   ##
=======================================
- Coverage   57.2%   56.4%   -0.9%     
=======================================
  Files        143     144      +1     
  Lines      17464   17717    +253     
=======================================
- Hits        9999    9997      -2     
- Misses      7465    7720    +255     
Impacted Files Coverage Δ
opentelemetry-api/src/global/metrics.rs 0.0% <0.0%> (ø)
opentelemetry-api/src/global/trace.rs 28.6% <0.0%> (ø)
opentelemetry-api/src/metrics/meter.rs 38.3% <0.0%> (ø)
opentelemetry-api/src/metrics/noop.rs 5.6% <0.0%> (ø)
opentelemetry-api/src/trace/mod.rs 87.2% <ø> (ø)
opentelemetry-api/src/trace/noop.rs 52.7% <0.0%> (ø)
...elemetry-contrib/src/trace/exporter/jaeger_json.rs 0.0% <0.0%> (ø)
opentelemetry-datadog/src/exporter/mod.rs 24.1% <0.0%> (ø)
opentelemetry-jaeger/src/exporter/config/mod.rs 82.0% <0.0%> (ø)
opentelemetry-prometheus/src/lib.rs 84.6% <ø> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cijothomas cijothomas closed this Apr 11, 2023
@cijothomas cijothomas reopened this Apr 11, 2023
@cijothomas cijothomas closed this Apr 13, 2023
@cijothomas cijothomas reopened this Apr 13, 2023
@cijothomas cijothomas closed this Apr 13, 2023
@cijothomas cijothomas reopened this Apr 13, 2023
@cijothomas cijothomas closed this Apr 13, 2023
@cijothomas cijothomas reopened this Apr 13, 2023
@hdost hdost linked an issue Apr 14, 2023 that may be closed by this pull request
@cijothomas cijothomas closed this Apr 18, 2023
@cijothomas cijothomas reopened this Apr 18, 2023
yup-oauth2's new version is using hyper-rustls 0.24 under the hood so it caused a version mismatch
@cijothomas cijothomas closed this Apr 19, 2023
@cijothomas cijothomas reopened this Apr 19, 2023
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@TommyCpp
Copy link
Contributor

Pushed a commit to fix the issue caused by #1018. I will open another PR to address the root case and revert the commit.

@cijothomas
Copy link
Member Author

Pushed a commit to fix the issue caused by #1018. I will open another PR to address the root case and revert the commit.

Can you merge this please?

@jtescher jtescher merged commit 93eae5d into open-telemetry:main Apr 20, 2023
@cijothomas cijothomas deleted the cijothomas/useotlpforjaeger branch April 21, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecating opentelemetry-jaeger
4 participants