-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Actix example to use OTLP ingestion for Jaeger #1022
Modify Actix example to use OTLP ingestion for Jaeger #1022
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
- Coverage 57.2% 56.4% -0.9%
=======================================
Files 143 144 +1
Lines 17464 17717 +253
=======================================
- Hits 9999 9997 -2
- Misses 7465 7720 +255
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
yup-oauth2's new version is using hyper-rustls 0.24 under the hood so it caused a version mismatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Pushed a commit to fix the issue caused by #1018. I will open another PR to address the root case and revert the commit. |
Can you merge this please? |
Related to this : #995
This PR modifies the Actix-Http example to use OTLP Exporter instead of Jaeger Exporter. The name of the project is still "actix-http".
There are quite a few examples with actix showing http/hyper/udp. It could be consolidated to a single one. If there is a desire to consolidate, I can propose a PR for that separately.