Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to jaeger docs about future deprecation: #996

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

cijothomas
Copy link
Member

Towards #995.
This does not deprecate anything. Instead a warning about a future deprecation is added to the docs, so users can start switch to OTLP one sooner.

Note:
rust-lang/rust#106561 is not yet merged, so I could not find any better way to put a "Warning" thing into the doc. Open to any suggestions!

@cijothomas cijothomas requested a review from a team March 14, 2023 01:59
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.1 ⚠️

Comparison is base (62450b9) 69.9% compared to head (7ac0b25) 69.9%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #996     +/-   ##
=======================================
- Coverage   69.9%   69.9%   -0.1%     
=======================================
  Files        116     116             
  Lines       8922    8922             
=======================================
- Hits        6245    6239      -6     
- Misses      2677    2683      +6     
Impacted Files Coverage Δ
opentelemetry-jaeger/src/lib.rs 93.3% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cijothomas cijothomas closed this Mar 14, 2023
@cijothomas cijothomas reopened this Mar 14, 2023
Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been talking about creating a contrib potentially even if after we decide to remove we could always move it to contrib.

@jtescher jtescher merged commit 0d666d4 into open-telemetry:main Mar 14, 2023
@cijothomas cijothomas deleted the cijothomas/jaeger-warning branch March 14, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants