Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jaeger crate from tracing example deps #1393

Merged

Conversation

cijothomas
Copy link
Member

Towards #995

Changes

Removed unwanted dependency from example. The example was already using OTLPExporter!
Minor wording change to indicate opentelemetry-jaeger is to be used for jaeger propagators, not for exporters.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team November 22, 2023 18:07
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e1c8c1) 57.2% compared to head (324df6b) 57.2%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1393   +/-   ##
=====================================
  Coverage   57.2%   57.2%           
=====================================
  Files        146     146           
  Lines      18128   18128           
=====================================
  Hits       10371   10371           
  Misses      7757    7757           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 073f7a6 into open-telemetry:main Nov 22, 2023
15 checks passed
@cijothomas cijothomas deleted the cijothomas/move-towards-jaeger-dep branch November 22, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants