-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cardinality limits for metric streams #1066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
=======================================
- Coverage 50.9% 50.8% -0.1%
=======================================
Files 165 165
Lines 19689 19751 +62
=======================================
+ Hits 10025 10037 +12
- Misses 9664 9714 +50
☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
May 19, 2023
lzchen
changed the title
[WIP] Implement cardinality limits for metric streams
Implement cardinality limits for metric streams
May 19, 2023
cijothomas
reviewed
May 23, 2023
jtescher
reviewed
May 24, 2023
jtescher
reviewed
May 25, 2023
jtescher
approved these changes
May 25, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1065
This PR implements a fixed cardinality limit for metric data points of the same stream to 2000. If an attempt to use an instrument to create a new metric data point for the same stream is made which would exceed the limit, the data point is added/recorded to the data point representing the overflow metric stream which is denoted by an
AttributeSet
containing only{otel.metric.overflow: True}
.Note there is a bit of duplication of code done on purpose to optimize for the most common scenarios, which is usually when an entry exists already within a hashmap.