Re-use memory via aggregate functions #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies memory reuse on subsequent collection cycles. Also small ergonomics changes: * Move `MetricsProducer` config to builders to match other config * Remove the need for separate `Delta*` and `Cumulative*` aggregate types * Return error earlier if readers are shut down * Log warning if two instruments have the same name with different casing * Log warning if view is created with empty criteria
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
shaun-cox
approved these changes
Sep 13, 2023
TommyCpp
reviewed
Sep 13, 2023
|
|
||
| /// Checks whether aggregator has hit cardinality limit for metric streams | ||
| pub(crate) fn is_under_cardinality_limit(size: usize) -> bool { | ||
| size < STREAM_CARDINALITY_LIMIT as usize - 1 |
There was a problem hiding this comment.
Why we -1 here? Does it mean 1999 should return false?
There was a problem hiding this comment.
I guess this was added in #1066. Return false for 1999, as the overflow measurements are aggregated in a separate metric stream. So total number of metric streams remain 2000.
There was a problem hiding this comment.
yeah this one is also unchanged from before (aside from removing the unused &self param)
There was a problem hiding this comment.
Got it. We should probably add it to comment to make it clearer
TommyCpp
approved these changes
Sep 13, 2023
lalitb
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This simplifies memory reuse on subsequent collection cycles.
Also small ergonomics changes:
MetricsProducerconfig to builders to match other configDelta*andCumulative*aggregate typesMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes