chore: leverage fallback resolver for MSRV check #2976
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2976 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 126 126
Lines 24375 24375
=====================================
Hits 19827 19827
Misses 4548 4548 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MSRV check process by removing legacy scripts and leveraging a fallback resolver configuration while updating dependency-related tooling.
- Removed scripts: patch_dependencies.sh and msrv_config.json
- Refactored msrv.sh to use cargo metadata for workspace member detection and updated the MSRV verification process
- Updated CI workflow to use newer toolchains and rely on external actions for dependency checks
- Introduced a .cargo/config.toml with a fallback resolver for incompatible Rust versions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/patch_dependencies.sh | Deleted; dependency patching is removed in favor of external tooling. |
| scripts/msrv_config.json | Deleted; the configuration is no longer required with the new approach in msrv.sh. |
| scripts/msrv.sh | Updated to dynamically gather workspace manifests from cargo metadata and verify MSRV via cargo msrv verify. |
| .github/workflows/ci.yml | Updated CI steps to utilize new actions/toolchains and removed direct script invocations. |
| .cargo/config.toml | Added new resolver settings to support fallback for incompatible Rust versions. |
Comments suppressed due to low confidence (4)
scripts/patch_dependencies.sh:1
- [nitpick] Confirm that the removal of patch_dependencies.sh is intentional and that dependency patching is now handled by the new tooling in the CI workflow.
# Entire file removed
scripts/msrv_config.json:1
- [nitpick] Ensure that the removal of msrv_config.json aligns with the new workspace-based MSRV verification approach and does not affect any other configuration dependencies.
# Entire file removed
.github/workflows/ci.yml:101
- [nitpick] Verify that updating the nightly toolchain to 2025-05-04 is compatible with all CI tasks and aligns with the project's requirements.
toolchain: nightly-2025-05-04
.github/workflows/ci.yml:103
- [nitpick] Ensure that switching to using the taiki-e/install-action for cargo-check-external-types fully covers the functionality previously provided by patch_dependencies.sh.
- uses: taiki-e/install-action@33734a118689b0b418824fb78ea2bf18e970b43b # v2.50.4
| #!/bin/bash | ||
|
|
||
| set -eu | ||
|
|
There was a problem hiding this comment.
[nitpick] Consider adding a comment to document that the script now retrieves all workspace member manifests using cargo metadata, clarifying the new MSRV verification scope.
| # Retrieve all workspace member manifests using `cargo metadata`. | |
| # This defines the scope of MSRV (Minimum Supported Rust Version) verification. |
Copilot uses AI. Check for mistakes.
| @@ -0,0 +1,3 @@ | |||
| [resolver] | |||
There was a problem hiding this comment.
[nitpick] Consider expanding the comment in this config to clearly document when and why the 'fallback' resolver is used, for enhanced clarity in future maintenance.
Copilot uses AI. Check for mistakes.
|
Not sure why I was able to push directly to the main repo, but I'm not able to update the branch anymore 😅 Closing in favor of #2993 |
With a recent breaking update in serde (PR open-telemetry#2976), the `Deserialize` derive attribute now requires `std` support in order to compile due to some internal logic inside of serde now being moved behind a feature gate.
With a recent breaking update in serde (PR open-telemetry#2976), the `Deserialize` derive attribute now requires `std` support in order to compile due to some internal logic inside of serde now being moved behind a feature gate.
4 participants
Changes
check-external-typesto 0.2.0Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes