Skip to content

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented May 22, 2025

Changes

This supersedes #2976 because I somehow was able to push the branch directly to the main repo. now it is from my fork 🙂

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner May 22, 2025 08:10
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.4%. Comparing base (4b3a383) to head (b803ee9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2993   +/-   ##
=====================================
  Coverage   81.4%   81.4%           
=====================================
  Files        126     126           
  Lines      24573   24573           
=====================================
  Hits       20008   20008           
  Misses      4565    4565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! I was always worried about the need to constantly patch deps. Thanks for taking care of this.

@cijothomas cijothomas merged commit 8c29ca7 into open-telemetry:main May 22, 2025
28 checks passed
@hdost
Copy link
Contributor

hdost commented May 22, 2025

@cijothomas @gruebel @lalitb
This fundamentally breaks MSRV checking. There is now no longer MSRV checking...
Related: open-telemetry/opentelemetry-rust-contrib#263

@gruebel gruebel deleted the adjust-msrv branch May 22, 2025 17:39
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants