fix: Add std feature to serde to fix CI linting issues
#3165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3165 +/- ##
=====================================
Coverage 80.6% 80.6%
=====================================
Files 126 126
Lines 22195 22195
=====================================
Hits 17898 17898
Misses 4297 4297 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With a recent breaking update in serde (PR open-telemetry#2976), the `Deserialize` derive attribute now requires `std` support in order to compile due to some internal logic inside of serde now being moved behind a feature gate.
lucamuscat
changed the title
std feature to serde to fix linting issuesstd feature to serde to fix CI linting issues
4 tasks
…d-external-types.toml` following the recent breaking changes introduced in serde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue (if applicable) #
Changes
With a recent breaking update in serde (PR #2976), the
Deserializederive attribute now requiresstdsupport in order to compile theopentelemetry-protocrate due to some internal logic inside of serde now being moved behind a feature gate.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes