Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking: Exemplar Specification - Stabilization #3756

Closed
7 of 8 tasks
jsuereth opened this issue Nov 3, 2023 · 2 comments · Fixed by #3870
Closed
7 of 8 tasks

Tracking: Exemplar Specification - Stabilization #3756

jsuereth opened this issue Nov 3, 2023 · 2 comments · Fixed by #3870
Assignees
@jsuereth @arminru
Labels
[label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:metrics Related to the specification/metrics directory

Comments

@jsuereth
Copy link
Contributor

jsuereth commented Nov 3, 2023 •
edited
Loading

This bug is tracking issues that must be resolved before Exemplars can be declared stable.
@jsuereth jsuereth added the spec:metrics Related to the specification/metrics directory label Nov 3, 2023
@jsuereth jsuereth self-assigned this Nov 3, 2023
@arminru arminru changed the title Tracking: Exemplar Specification - Stabilizatoin Tracking: Exemplar Specification - Stabilization Nov 7, 2023
@jsuereth jsuereth mentioned this issue Nov 10, 2023
Merged
@arminru arminru added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Nov 15, 2023
jmacd added a commit that referenced this issue Dec 1, 2023
@jsuereth @dashpole @jmacd
Clarifications and "flexibility" fixes in Exemplar Specification (#3760)
bb3d0a0 
Fixes #2205
Fixes #3674 
Fixes #3669
Partially fixes #2421

## Changes

- Update example exemplar algorithm to account for initial reservoir
fill
- Update fixed-size defaults to account for memory contention /
optimization in Java impl
- Set a default for exponential histogram aggregation
- Clarify that ExemplarFilter should be configured on MeterProvider
- Make it clear that ONE reservoir is create PER timeseries datapoint
(not one reservoir per view or metric name).
- Allow flexibility in Reservoir `offer` definition based on feedback
from Go impl.

* Related issues #3756

---------

Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
@jsuereth jsuereth mentioned this issue Jan 12, 2024
Merged
carlosalberto pushed a commit that referenced this issue Jan 31, 2024
@jsuereth
Expose ExemplarReservoir as configuration option of View. (#3820)
c0491fb 
Fixes #2922
Fixes #3812 
Related to #3756

## Changes

- Cleans up language around exposing `ExemplarReservoir`. (Remove TODO,
e.g.)
- Remove `ExemplarFilter` interface but keep configuration options. (see
#3812)
- Clarify / simplify Spec Compliance matrix for existing state of the
Exemplar Specification.


Prototype in java:
open-telemetry/opentelemetry-java#5960
@jsuereth jsuereth mentioned this issue Feb 8, 2024
Merged
5 tasks
@jack-berg
Copy link
Member

Added Clarify that exemplars are best effort and changing defaults are non-breaking per this conversation: #3870 (comment)

@jack-berg jack-berg mentioned this issue Mar 15, 2024
Merged
@reyang
Copy link
Member

reyang commented Mar 15, 2024

The TC discussed this during the Mar. 13th, 2024 meeting:

  1. There is only one blocking issue (more details can be found from Tracking: Exemplar Specification - Stabilization #3756), @jack-berg is working on it Clarify that exemplar reservoir default may change in a minor version #3943.
  2. After PR Clarify that exemplar reservoir default may change in a minor version #3943 is merged, we should be ready to move this PR forward. We're targeting mid Apr. for the Metrics Exemplar spec to be marked Stable (spec release will happen early May).

jack-berg added a commit that referenced this issue Mar 20, 2024
@jack-berg @reyang
Clarify that exemplar reservoir default may change in a minor version (…
7145a5d 
…#3943)

Related to #3756. 

See this
[conversation](#3870 (comment))
for context.

---------

Co-authored-by: Reiley Yang <reyang@microsoft.com>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@jsuereth @dashpole @jmacd
Clarifications and "flexibility" fixes in Exemplar Specification (ope…
c03ebe6 
…n-telemetry#3760)

Fixes open-telemetry#2205
Fixes open-telemetry#3674 
Fixes open-telemetry#3669
Partially fixes open-telemetry#2421

## Changes

- Update example exemplar algorithm to account for initial reservoir
fill
- Update fixed-size defaults to account for memory contention /
optimization in Java impl
- Set a default for exponential histogram aggregation
- Clarify that ExemplarFilter should be configured on MeterProvider
- Make it clear that ONE reservoir is create PER timeseries datapoint
(not one reservoir per view or metric name).
- Allow flexibility in Reservoir `offer` definition based on feedback
from Go impl.

* Related issues open-telemetry#3756

---------

Co-authored-by: David Ashpole <dashpole@google.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@jsuereth
Expose ExemplarReservoir as configuration option of View. (open-tel…
2dfedfe 
…emetry#3820)

Fixes open-telemetry#2922
Fixes open-telemetry#3812 
Related to open-telemetry#3756

## Changes

- Cleans up language around exposing `ExemplarReservoir`. (Remove TODO,
e.g.)
- Remove `ExemplarFilter` interface but keep configuration options. (see
open-telemetry#3812)
- Clarify / simplify Spec Compliance matrix for existing state of the
Exemplar Specification.


Prototype in java:
open-telemetry/opentelemetry-java#5960
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@jack-berg @reyang
Clarify that exemplar reservoir default may change in a minor version (…
da4048f 
…open-telemetry#3943)

Related to open-telemetry#3756. 

See this
[conversation](open-telemetry#3870 (comment))
for context.

---------

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuereth jsuereth

@arminru arminru

Labels
[label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark exemplars as stable. jsuereth/opentelemetry-specification
4 participants
@jsuereth @arminru @reyang @jack-berg