Expose ExemplarReservoir as configuration option of View.
#3820
Conversation
…voir implementations.
…d as an interface.
jsuereth
force-pushed
the
wip-exemplar-in-view
branch
from
8d476fa to
792aa84
Compare
|
How is #2922 resolved by this PR? I am not able to see how that issue is being addressed here. |
Can you add this to changelog as well ? Also, its not clear from PR description why we are removing the ability to author custom ExemplarFilter? Is that temporarily done to unblock stable release? Or we don't see the need of custom ExemplarFilters at all? |
I see. It'd good to describe in PR desc, how is this achieved so future readers can know how to achieve. Otherwise, merging this PR would just close the associated issue, without a clear description of how it was closed. |
Yeah, there was concern in the Specification meeting that We're err-ing on "less in the initial release is better", and we have the ability to bring back the interface if needed in the future. |
|
@jsuereth I think we are more than ready to merge this one! Please resolve the conflicts in the compliance matrix, etc. |
…emetry#3820) Fixes open-telemetry#2922 Fixes open-telemetry#3812 Related to open-telemetry#3756 ## Changes - Cleans up language around exposing `ExemplarReservoir`. (Remove TODO, e.g.) - Remove `ExemplarFilter` interface but keep configuration options. (see open-telemetry#3812) - Clarify / simplify Spec Compliance matrix for existing state of the Exemplar Specification. Prototype in java: open-telemetry/opentelemetry-java#5960
Fixes #2922
Fixes #3812
Related #3756
Changes
ExemplarReservoir. (Remove TODO, e.g.)ExemplarFilterinterface but keep configuration options. (see Can the exemplar filter and reservoir be merged? #3812)Prototype in java: open-telemetry/opentelemetry-java#5960