-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTracing compatibility section. #1101
Add OpenTracing compatibility section. #1101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with the document in current form, even though I have a few questions and suggested improvements - like semantical convention mapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a functional prototype of this design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor suggestions.
Hey @yurishkuro I finally managed to update the document as suggested in the previous review. A few things to summarize the state:
The final important item to be discussed is your comment:
To which I had answered:
Let me know ;) |
Merging as we have enough approvals, and have filled the following issues as follow ups: #1511 Execution Unit clarification @yurishkuro please feel free to open any other follow up, I will be happy to address it. I think now we need to go out and validate with Go/Python to finish validating (or correcting) the current approach. |
Fixes #114
This is a second attempt after #768 was closed ;) It applies all the feedback, leaving the so-called back-propagation of
Baggage
out, given its complexity in the implementation. It can be added later if/as needed:cc @pavolloffay @tedsuo @yurishkuro