Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTracing compatibility section. #1101
Add OpenTracing compatibility section. #1101
Changes from 30 commits
1c9bc9d
bcdfb00
3195643
92da36f
dd331ab
b944a2c
c6027ba
272198e
bf66d04
36043f6
57ed80a
d1ce668
88fa597
5c8bc99
7ded0ce
1567a97
155a286
d92c209
597fff7
e5deff1
bb173ca
a6fd708
10d4ac4
69d1424
1920d88
b569ee9
0dff253
439f484
c18c10b
ab02876
40b396c
d65fcdc
42a55e7
c783567
8547dc4
1fb02e6
350310f
1e842c7
2a8dd16
cfcb3d5
8c2d494
3c5f040
b1296a7
c340224
c2281fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to understand the purpose of these paragraphs. Are they trying to describe a difference in behavior between OT and OTEL baggage? Specifically, in OT the
span.setBaggage
operation is change-in-place and affects what baggage can be seen by different threads (and, therefore, has an inherent race condition, due to OT design). In contrast, OTEL stores baggage in the Context and removes this race condition by design, but it is not clear to be how the shim deals with it since the Context is never mentioned. If we carry the Baggage object directly in the SpanContext shim, then it can reproduce the same OT behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Java and C#
Baggage
exists in its own object, which basically means we can leaveContext
entirely out (at least for those languages).This is indeed the reason I'm mentioning here the details. However, I'm also trying to keep the invariant of an actual
SpanContext
being entirely replaced:If you think this invariant is not worth keeping (and it's enough to simply keep the actual values consistent), I can try to play around and simplify things.