Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semconv: adjust doc-page titles #2984

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 7, 2023

Preview: https://deploy-preview-2984--opentelemetry.netlify.app/docs/specs/semconv/

/cc @jsuereth @joaopgrassi

@chalin chalin requested a review from a team July 7, 2023 13:15
@chalin chalin marked this pull request as draft July 7, 2023 14:34
@chalin chalin force-pushed the chalim-im-semconv-titles-2023-07-07 branch from 2fb1414 to ac35aab Compare July 7, 2023 15:13
@chalin chalin marked this pull request as ready for review July 7, 2023 15:13
@chalin chalin requested a review from a team July 7, 2023 15:29
@chalin
Copy link
Contributor Author

chalin commented Jul 7, 2023

@jsuereth @joaopgrassi - since the semconv pages are still only visible in Netlify previews, I'm going to merge this now because I have followup changes to make to the scripts. Feedback is still welcome -- I'll address it, if any, in a subsequent PR.

@chalin chalin merged commit f9496ef into open-telemetry:main Jul 7, 2023
@chalin chalin deleted the chalim-im-semconv-titles-2023-07-07 branch July 7, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants