Ensure that semconv pages are preview only, not in production + add watermark #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
chalin-im-semconv-draft-2023-07-10
branch
from
0a263f2
to
309c24a
Compare
|
Btw, I can also change the watermark text to be DRAFT. |
svrnm
approved these changes
Jul 11, 2023
chalin
force-pushed
the
chalin-im-semconv-draft-2023-07-10
branch
from
86793fd
to
1d99caa
Compare
|
I've switched to the DRAFT watermark. |
|
@jsuereth - Going to merge this now before the semconv pages get too much traffic -- the pages weren't meant to be published (yet) in the first place. Apologies for the churn! |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jsuereth @joaopgrassi - my apologies, but #2984 inadvertently caused the semconv pages to be published to the production server (confusion arose as I switched to using the name-title adjustment script and forgot that I had dropped the
draft: truefront matter field).This PR:
(was: PREVIEW-ONLY)wartermark for the semconv draft pagesGiven that the semconv pages are pretty much in their final form (given that the reorg is done), maybe we can keep the pages in production, but with the watermark. Or even just forget about the watermark too? Your call, let me know.
Preview: https://deploy-preview-3008--opentelemetry.netlify.app/docs/specs/semconv/
Screenshot: