Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSBUILD-failure path issue #3707

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Fix JSBUILD-failure path issue #3707

merged 4 commits into from
Dec 22, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Dec 22, 2023

No description provided.

@svrnm
Fix path issue
fae5a68 
Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm svrnm requested a review from a team December 22, 2023 16:37
@svrnm
right package
d855175 
Signed-off-by: svrnm <neumanns@cisco.com>
@austinlparker austinlparker merged commit 7c2a564 into open-telemetry:main Dec 22, 2023
14 checks passed
@chalin
Copy link
Contributor

chalin commented Jan 8, 2024

Thanks for noticing the build error @svrnm and/or @austinlparker. Strange, I can't see what changed that might have affected the production build. Anyhow, I'm glad that this is resolved.

This was referenced Jan 8, 2024
Closed
Open
@chalin
Copy link
Contributor

chalin commented Jan 8, 2024

Followups:

@chalin chalin changed the title Fix path issue Fix JSBUILD-failure path issue Jan 8, 2024
@svrnm svrnm deleted the fix-path-issue branch January 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinlparker austinlparker austinlparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svrnm @chalin @austinlparker