-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese translation for "What is OpenTelemetry?" #4606
Conversation
@chalin May I ask a quick question? This PR failed because of a missing target.
Is this something that #4599 helps? |
@svrnm oh, I did change the path unexpectedly. Thank you for catching the cause! |
Thanks all. I have some meetings now, but will come back to this PR. I noticed a few things but don't have time to comment more fully yet, so I've marked this as draft in the meantime. |
fix path issue Co-authored-by: Severin Neumann <neumanns@cisco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
LGTM |
@ymotongpoo - note the |
Thank you @chalin for merging and sharing the commit that adds a revision snapshot of my translation. Can I assume the following PRs will get similar additions by the automated scripts or do I need to add that metadata by myself? |
Hi @ymotongpoo - the GitHub action only checks whether you've added the necessary commit hash. You'll need to add them yourself based on your knowledge of the commit hash of the English language version of the page(s) you are translating -- which might not be at If you are working from |
Thank you @chalin for clarifying the process. Then I will add the revisions in the upcoming PRs. |
Docs PR Checklist
opentelemetry.io repository.
Preview: https://deploy-preview-4606--opentelemetry.netlify.app/ja/docs/