Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translation for "What is OpenTelemetry?" #4606

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

ymotongpoo
Copy link
Contributor

@ymotongpoo ymotongpoo commented Jun 6, 2024

Docs PR Checklist

  • This PR is for a documentation page whose authoritative copy is in the
    opentelemetry.io repository.

Preview: https://deploy-preview-4606--opentelemetry.netlify.app/ja/docs/

@ymotongpoo ymotongpoo requested a review from a team June 6, 2024 02:47
@ymotongpoo
Copy link
Contributor Author

ymotongpoo commented Jun 6, 2024

@chalin May I ask a quick question? This PR failed because of a missing target.

> __check:links
> make --keep-going check-links

rm -Rf tmp/bin
curl https://htmltest.wjdp.uk | bash -s -- -b tmp/bin
mkdir -p tmp/.htmltest
cp static/refcache.json tmp/.htmltest/
tmp/bin/htmltest --log-level 1
htmltest started at 02:48:47 on public
========================================================================
running in concurrent mode, this is experimental
ja/docs/index.html
  target does not exist --- ja/docs/index.html --> concepts/observability-primer/#what-is-observability
========================================================================
✘✘✘ failed in 1m2.997326825s
1 errors in [87](https://github.com/open-telemetry/opentelemetry.io/actions/runs/9394342440/job/25871928540?pr=4606#step:4:88)6 documents
cp tmp/.htmltest/refcache.json static/
npm run _prettier:any -- --write static/refcache.json

Is this something that #4599 helps?

content/ja/docs/_index.md Outdated Show resolved Hide resolved
@ymotongpoo
Copy link
Contributor Author

@svrnm oh, I did change the path unexpectedly. Thank you for catching the cause!

@chalin chalin marked this pull request as draft June 6, 2024 13:55
@chalin chalin self-assigned this Jun 6, 2024
@chalin
Copy link
Contributor

chalin commented Jun 6, 2024

Thanks all. I have some meetings now, but will come back to this PR. I noticed a few things but don't have time to comment more fully yet, so I've marked this as draft in the meantime.

content/ja/docs/what-is-opentelemetry.md Outdated Show resolved Hide resolved
@ymotongpoo ymotongpoo marked this pull request as ready for review June 7, 2024 00:57
@svrnm svrnm added the lang:ja label Jun 7, 2024
Yoshi Yamaguchi and others added 3 commits June 7, 2024 07:13
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin
Copy link
Contributor

chalin commented Jun 7, 2024

LGTM
FYI, I'll setup fallback pages in a followup PR.

@chalin chalin merged commit 93ab130 into open-telemetry:main Jun 7, 2024
15 checks passed
@chalin
Copy link
Contributor

chalin commented Jun 7, 2024

@ymotongpoo - note the default_lang_commit fields added to the pages of this PR via:

@ymotongpoo
Copy link
Contributor Author

Thank you @chalin for merging and sharing the commit that adds a revision snapshot of my translation. Can I assume the following PRs will get similar additions by the automated scripts or do I need to add that metadata by myself?

@chalin
Copy link
Contributor

chalin commented Jun 7, 2024

Hi @ymotongpoo - the GitHub action only checks whether you've added the necessary commit hash. You'll need to add them yourself based on your knowledge of the commit hash of the English language version of the page(s) you are translating -- which might not be at main@HEAD.

If you are working from en pages @HEAD then you can run the script mention in https://opentelemetry.io/docs/contributing/localization/#adding-default_lang_commit-to-new-pages.

@ymotongpoo
Copy link
Contributor Author

Thank you @chalin for clarifying the process. Then I will add the revisions in the upcoming PRs.

@ymotongpoo ymotongpoo deleted the ja/docs/index branch June 7, 2024 23:28
ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants