-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Add Japanese translation for getting started #4616
[ja] Add Japanese translation for getting started #4616
Conversation
This PR needs to be merged after #4606 |
@ymotongpoo - hmm, there are issues with this PR, as can be surmised from the many labels that the labeling bot automatically added to this PR: If you can, please to the following from your local environment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've submitted link-normalization updates to [i18n & ja] Improved fallback config and normalize
en
doc links #4627 that will make it easier to keep the same link paths in this PR. So until that PR is merged, this one will be blocked (FYI) - See inline comment.
9f3bbce
to
00a203f
Compare
@chalin thank you for the comment. I force-pushed this branch. I hope it should fix the labels afterwards. (I don't have permission to change labels and GH Actions hasn't changed the labels yet.) |
I am not sure if the tooling is able to remove labels that have been set before, I manually removed them |
Thanks. Did you rebase first? There is still a problem with the PR in that we can't rebase from the web i/f: Follow the instructions given earlier #4616 (comment):
The following PR has been merged and so this PR needs to be rebased because of that: |
@chalin Hmm, I rebased my fork first, rebased it with upstream/main, force-pushed then I added a couple more commits. I can't figure out why you are not able merge this PR. Let me try another force push. |
4949c15
to
81085bc
Compare
@chalin I hope this push made it work. |
- [C++](/docs/languages/cpp/) | ||
- [.NET](/docs/languages/net/) | ||
- [Erlang / Elixir](/docs/languages/erlang/) | ||
- [Go](/docs/languages/go/) | ||
- [Java](/docs/languages/java/) | ||
- [JavaScript / TypeScript](/docs/languages/js/) | ||
- [PHP](/docs/languages/php/) | ||
- [Python](/docs/languages/python/) | ||
- [Ruby](/docs/languages/ruby/) | ||
- [Rust](/docs/languages/rust/) | ||
- [Swift](/docs/languages/swift/) | ||
- [Other](/docs/languages/other/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this page and the others too, ensure that you apply the changes made via:
Otherwise, the links given here refer to the en
pages, which isn't what we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I change them to point to ja pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather that you use relative paths as is done in the en
page. That way we keep the ja
and en
versions "in sync".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that #4627 was merged 2 days ago, so if I rebase onto main
yesterday, the change was applied. Is it correct?
Anyway, I misunderstood your comment so I reverted the path change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries @ymotongpoo. Merging of translation PRs is on hold. I'll get back to you as soon as I can.
825a538
to
35c10b5
Compare
b6d060d
to
dd6e341
Compare
44e8879
to
fbefc20
Compare
I deleted the remote branch by mistake. Reopening. |
@chalin @svrnm let me check the status. my understanding is that required steps to merge this and upcoming PRs are:
Is this correct? |
fbefc20
to
6e83441
Compare
We are able to merge the PR without that being complete, we need to make this happen, but technically the PR is ready, however all translation PRs will be on hold / throttled back (not only new ones), as @chalin works on resolving core issues with the i18n-support features. |
6e83441
to
91c4f4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ymotongpoo - ok, I see what is happening. You've specified that this PR is based on the English files from commit 93ab130. There have been updates to the pages in this PR since then.
Please use the following commit (or any more recent one) as your English-language file base:
You can see the diff here:
Also note that the Localization page instructions and script have changed. For the updated pages, see: By the time that you are done updating this PR, when you run |
Thank you @chalin for the confirmation. Because this is the PR for files under "Getting Started", I just updated the base revision of files under Thanks to your script, I'm aware that the following files need to be updated similarly, which will be fixed in the following PRs.
|
Yes, that is ok. For this PR I wanted to ensure that the Getting started pages reflected the latest |
5701f63
to
8543558
Compare
8543558
to
90e2e0b
Compare
Rebased PR that conforms to the new Translation tips. All checks are passing, so I'll merge this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
en
doc links #4627Preview: https://deploy-preview-4616--opentelemetry.netlify.app/ja/docs/getting-started/