-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n & ja] Improved fallback config and normalize en
doc links
#4627
Merged
chalin
merged 6 commits into
open-telemetry:main
from
chalin:chalin-im-ja-docs-fallback-2024-06-07
Jun 8, 2024
Merged
[i18n & ja] Improved fallback config and normalize en
doc links
#4627
chalin
merged 6 commits into
open-telemetry:main
from
chalin:chalin-im-ja-docs-fallback-2024-06-07
Jun 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 7, 2024
chalin
changed the title
[i18n] Fallback to en for ja docs; en docs link normalization
[i18n] Improved fallback configuration & Jun 7, 2024
en
docs link normalization
chalin
changed the title
[i18n] Improved fallback configuration &
[i18n] Improved fallback config, add ecosystem, and normalize Jun 7, 2024
en
docs link normalizationen
doc links
chalin
force-pushed
the
chalin-im-ja-docs-fallback-2024-06-07
branch
from
June 7, 2024 22:23
d8b618c
to
d20ece7
Compare
windsonsea
reviewed
Jun 7, 2024
chalin
force-pushed
the
chalin-im-ja-docs-fallback-2024-06-07
branch
from
June 7, 2024 23:00
d20ece7
to
7009e9e
Compare
chalin
changed the title
[i18n] Improved fallback config, add ecosystem, and normalize
[i18n] Improved fallback config and normalize Jun 7, 2024
en
doc linksen
doc links
chalin
force-pushed
the
chalin-im-ja-docs-fallback-2024-06-07
branch
from
June 7, 2024 23:03
7009e9e
to
ef224f7
Compare
Sigh, no this isn't ready. I got over ambitious with the fallback config by trying to cover as many sections as possible. Need to backtrack. Setting back to draft until then 🤷🏼♂️ |
chalin
changed the title
[i18n] Improved fallback config and normalize
[i18n & ja] Improved fallback config and normalize Jun 8, 2024
en
doc linksen
doc links
This is ready for review once again. |
chalin
force-pushed
the
chalin-im-ja-docs-fallback-2024-06-07
branch
from
June 8, 2024 09:24
5a1200b
to
39e32ca
Compare
chalin
force-pushed
the
chalin-im-ja-docs-fallback-2024-06-07
branch
from
June 8, 2024 12:20
39e32ca
to
2399142
Compare
svrnm
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
en
pages to make localization easierja
andzh
to be more inclusivePreview: https://deploy-preview-4627--opentelemetry.netlify.app/ja/docs/
Followup:
content/en/docs/demo/screenshots
intostatic
to ensure that they are shared(?)