Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt-br] Localize index page to Portuguese (Brazil) #4794

Merged
merged 8 commits into from
Jul 17, 2024
Merged

[pt-br] Localize index page to Portuguese (Brazil) #4794

merged 8 commits into from
Jul 17, 2024

Conversation

edsoncelio
Copy link
Member

@edsoncelio edsoncelio commented Jul 4, 2024 •
edited by chalin
Loading

Changes

This is the new version of the PR #4615

  • Create /content/pt/_index.md
  • Add the language config to hugo.yaml

Preview

https://deploy-preview-4794--opentelemetry.netlify.app/pt/

Contributes to #4834

@edsoncelio edsoncelio mentioned this pull request Jul 4, 2024
Closed
@chalin chalin self-assigned this Jul 5, 2024
@chalin chalin added the i18n internationalization label Jul 5, 2024
@chalin chalin mentioned this pull request Jul 10, 2024
Merged
chalin
chalin requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment for required changes to the landing page.

The spell-check issues will go away once #4816 is merged. Later we can look into re-enabling spelling checks for pt pages.

I'll update soon after your next round of updates. Thanks!

content/pt/_index.md Outdated Show resolved Hide resolved
@chalin chalin marked this pull request as ready for review July 13, 2024 00:38
@chalin chalin requested a review from a team July 13, 2024 00:38
@chalin chalin mentioned this pull request Jul 13, 2024
Closed
7 tasks
chalin
chalin approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once another native pt-BR speaker can approve the homepage content.

See inline comment for minor nit.

I'm OOO next week, but I'm ok with this getting merged if you feel comfortable with that @theletterf.

content/pt/_index.md Outdated Show resolved Hide resolved
EzzioMoreira
EzzioMoreira reviewed Jul 13, 2024
View reviewed changes
content/pt/_index.md Outdated Show resolved Hide resolved
EzzioMoreira
EzzioMoreira reviewed Jul 13, 2024
View reviewed changes
content/pt/_index.md Outdated Show resolved Hide resolved
content/pt/_index.md Outdated Show resolved Hide resolved
@EzzioMoreira
Copy link
Contributor

LGTM 💯

jpkrohling
jpkrohling reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. The only thing I'd change is to name this translation "Portuguese (Brazil)".

content/pt/_index.md
@@ -0,0 +1,90 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should be pt-BR, not pt.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Juraci!
This was requested by chalin at the old PR.

I don't see this as a big problem; we are already using the language code for pt-br..

@edsoncelio
Copy link
Member Author

Looks awesome. The only thing I'd change is to name this translation "Portuguese (Brazil)".

Regarding this, I'm following the results of this discussion in the old PR - but in short: To maintain consistency with other languages, ​​we can use only "Portuguese."

@jpkrohling
Copy link
Member

Sounds good, if this was discussed before, I'm fine sticking with the outcome of that discussion.

edsoncelio and others added 2 commits July 17, 2024 09:33
@edsoncelio
Update content/pt/_index.md
9f9dda2 
Co-authored-by: Ezzio Moreira <ezzio.moreira@drcash.com.br>
@edsoncelio
Apply suggestions from code review
2665c65 
Co-authored-by: Ezzio Moreira <ezzio.moreira@drcash.com.br>
@svrnm svrnm merged commit 3c99d2c into open-telemetry:main Jul 17, 2024
16 checks passed
@edsoncelio edsoncelio deleted the add_ptbr_index branch July 17, 2024 17:18
@svrnm
Copy link
Member

svrnm commented Jul 17, 2024

thanks everyone, the PR is merged and the page is public:

https://opentelemetry.io/pt/ 🎉

@svrnm svrnm mentioned this pull request Jul 29, 2024
Closed
13 tasks
@edsoncelio edsoncelio mentioned this pull request Jul 31, 2024
Open
26 tasks
@EzzioMoreira EzzioMoreira mentioned this pull request Aug 11, 2024
Closed
6 tasks
@edsoncelio edsoncelio mentioned this pull request Sep 5, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzzioMoreira EzzioMoreira EzzioMoreira left review comments

@chalin chalin chalin approved these changes

@svrnm svrnm svrnm approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees

@chalin chalin

Labels
i18n internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edsoncelio @EzzioMoreira @jpkrohling @svrnm @chalin